Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/azservicebus: Set retry options in client on initalization #17686

Closed
andrholt opened this issue Apr 21, 2022 · 1 comment · Fixed by #17695
Closed

sdk/azservicebus: Set retry options in client on initalization #17686

andrholt opened this issue Apr 21, 2022 · 1 comment · Fixed by #17695
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Bus

Comments

@andrholt
Copy link

Set retryOptions in service bus client when initializing client

When initializing a new service bus client, a set of options can be provided. The retryOption property in client is never set from input parameter, it is only used to create namespace interface. When creating a new sender with client, default retryOptions is used, and not from clientOptions, and it is not possible to customize this. Is it possible to set retryOptions to client?

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Apr 21, 2022
@richardpark-msft richardpark-msft self-assigned this Apr 21, 2022
@richardpark-msft richardpark-msft added Service Bus Client This issue points to a problem in the data-plane of the library. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Apr 21, 2022
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Apr 21, 2022
@richardpark-msft
Copy link
Member

@andrholt, thank you for reporting this. Working on this now.

richardpark-msft added a commit that referenced this issue Apr 23, 2022
…the clients #17695

RetryOptions were not being propagated throughout all the clients (mismatch in old vs new system).

Fixed and added tests for the various spots that inherit these options to make sure they're properly getting copied over:
- Sender
- All the session receiver functions (AcceptNext, Accept)
- Receivers
- Namespace

Fixes #17686
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Bus
Projects
None yet
2 participants