Subscriptions List should include all the fields available in the API

[hermanschaaf]

Feature Request

The subscriptions Model struct includes a number of fields, but not all the fields available in the REST API according to the documentation. Specifically, the following fields are missing in the Go struct:

• tenantId - The subscription tenant ID.
• tags - The tags attached to the subscription.
• managedByTenants - An array containing the tenants managing the subscription.

We are particularly interested in the tenant ID in order to automatically determine the tenant for a given subscription.

[hermanschaaf]

After digging a bit more, I can see that this is because the fields are not part of the OpenAPI definition here: https://github.com/Azure/azure-rest-api-specs/blob/0c21498807897f2d523f3b63166a75e278ca0c64/specification/subscription/resource-manager/Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L210

However, these fields are returned by the API and are documented here: https://docs.microsoft.com/en-us/rest/api/resources/subscriptions/list?tabs=HTTP#subscription

Would the fix be to add the fields to the REST API definition? (And then regenerating the Go SDK) Would a PR to that effect be accepted?

[RickWinter]

The package you are using is part of the previous versions. The most recent version is available here:
https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/resourcemanager/subscription/armsubscription

[ghost]

Thank you for your feedback. This has been routed to the support team for assistance.

[hermanschaaf]

@RickWinter Thanks, I wasn't aware that I should be using the more recent version there.

Having checked that implementation, it seems like the new version is also missing subscription fields from the API like tenantId and tags:

azure-sdk-for-go/sdk/resourcemanager/subscription/armsubscription/zz_generated_models.go

Lines 445 to 465 in 77190ec

	// Subscription information.
	type Subscription struct {
	// The authorization source of the request. Valid values are one or more combinations of Legacy, RoleBased, Bypassed, Direct
	// and Management. For example, 'Legacy, RoleBased'.
	AuthorizationSource *string `json:"authorizationSource,omitempty"`
	// The subscription policies.
	SubscriptionPolicies *Policies `json:"subscriptionPolicies,omitempty"`
	// READ-ONLY; The subscription display name.
	DisplayName *string `json:"displayName,omitempty" azure:"ro"`
	// READ-ONLY; The fully qualified ID for the subscription. For example, /subscriptions/00000000-0000-0000-0000-000000000000.
	ID *string `json:"id,omitempty" azure:"ro"`
	// READ-ONLY; The subscription state. Possible values are Enabled, Warned, PastDue, Disabled, and Deleted.
	State *SubscriptionState `json:"state,omitempty" azure:"ro"`
	// READ-ONLY; The subscription ID.
	SubscriptionID *string `json:"subscriptionId,omitempty" azure:"ro"`
	}

Is there a way to map subscriptions to their tenants in either the new or the old SDK versions?

[navba-MSFT]

@hermanschaaf Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update. I have created the above PR and it is currently under review.

[hermanschaaf]

Hi @navba-MSFT, I see this issue has the needs-author-feedback tag attached to it--is there something I can help with at this stage?

[navba-MSFT]

The above PR is pending for quite sometime now. Adding Service team to look into this and take this forward.

[ghost]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @anuragdalmia, @ShilpiGautam, @ramaganesan-rg.

Issue Details

---

Feature Request

The subscriptions Model struct includes a number of fields, but not all the fields available in the REST API according to the documentation. Specifically, the following fields are missing in the Go struct:

• tenantId - The subscription tenant ID.
• tags - The tags attached to the subscription.
• managedByTenants - An array containing the tenants managing the subscription.

We are particularly interested in the tenant ID in order to automatically determine the tenant for a given subscription.

Author:	hermanschaaf
Assignees:	navba-MSFT
Labels:	question, Service Attention, Mgmt, customer-reported, Subscription, needs-team-attention, Previous Versions
Milestone:	-