Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain fork of http and tls in azure sdk #5

Closed
stevvooe opened this issue Dec 1, 2014 · 2 comments
Closed

Explain fork of http and tls in azure sdk #5

stevvooe opened this issue Dec 1, 2014 · 2 comments
Labels
question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@stevvooe
Copy link

stevvooe commented Dec 1, 2014

It looks like net/http and crypto/tls have been forked for use in the SDK. It would be nice to get an overview of why this was done, what changes were made and a road map to get the required changes into Go standard library, if possible.

The worry here is that it will be hard to vet the implementation for security and problematic to ensure fixes are backported from the standard library.
@ruslangabitov
Copy link
Contributor

Standard Go TLS library does not support TLS renegotiation. There is a patch for this issue, but it is not included into current Go release, and looks like it will not even make it into 1.4 or 1.5.

Patch:
https://gist.github.com/ruslangabitov/951ea755a3b76aa3f80f

You can find more information about this issue here:
https://code.google.com/p/go/issues/detail?id=5742

@stevvooe
Copy link
Author

stevvooe commented Dec 3, 2014

Thank you!

Its up to you if you want to close this ticket.

@ruslangabitov ruslangabitov added the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Dec 23, 2014
@ahmetb ahmetb closed this as completed Jan 26, 2015
@ruslangabitov ruslangabitov mentioned this issue Mar 26, 2015
Closed
@mcardosos mcardosos mentioned this issue Jan 11, 2017
Merged
AutorestCI added a commit that referenced this issue Apr 13, 2018
@AutorestCI
Generated from 6afef0622afc87e13e07128e6e5be89c1a50d709
f4c05fa 
Merge pull request #5 from TimeSeriesInsights/EnvironmentInfo-PartitionKeyProperty

Adding partitionKeyProperty to EnvironmentCreate and EnvironmentGet request.
AutorestCI added a commit that referenced this issue Apr 20, 2018
@AutorestCI
Generated from 5fa239f0f0abdd6dbba20252958288384b5fe797
d719281 
Fix Error status, fix version (#5)

* Remove error schema

* Add default response back

* Fix abandoned as system error

* Fix Error status

* Use preview tag

* Fix tag

* Remove error response schema as they are not used
AutorestCI added a commit that referenced this issue Apr 24, 2018
@AutorestCI
[AutoPR containerregistry/resource-manager] Azure Container Registry …
a1f4080 
…Auto Build Feature Swagger and examples (#1662)

* Generated from 8e3c1b45d0234eeebeab1d7ebdcc2a30ce1d7179

A few improvements and fixes (#4)

* A few improvements and fixes

* Fix the description for build arguments

* Remove error schema

* use 2017-10-01 tag

* Add default response back

* Generated from 5fa239f0f0abdd6dbba20252958288384b5fe797

Fix Error status, fix version (#5)

* Remove error schema

* Add default response back

* Fix abandoned as system error

* Fix Error status

* Use preview tag

* Fix tag

* Remove error response schema as they are not used

* Generated from 074adc160df8cd2dbe1c3295c478f7092ba09207

Fix CI (#7)

* Add python sdk version

* Add preview to namespace

* Remove an example

* Generated from 5e072f9f70cfd1ff9a8eb343e4d3d42e7c338a8a

Fix examples (#8)
AutorestCI added a commit that referenced this issue Sep 12, 2018
@AutorestCI
Generated from 71dbfe2c0b24d7b8295eaf5c6d2d8df6b08130ae
063c3d6 
Merge pull request #5 from AzureDataBox/gasdk

Azure rest api specs for GA of Databox
AutorestCI added a commit that referenced this issue Sep 12, 2018
@AutorestCI
Generated from 71dbfe2c0b24d7b8295eaf5c6d2d8df6b08130ae
b5dc5e2 
Merge pull request #5 from AzureDataBox/gasdk

Azure rest api specs for GA of Databox
AutorestCI added a commit that referenced this issue Sep 18, 2018
@AutorestCI
Generated from af2b72334f7829e4d9c19f0fe66a255e74af10e6
73cb27c 
Merge pull request #5 from hosunmsft/add_hq_node_to_adla_job_contract

add hierarchyQueueNode to JobInformation(Basic)
AutorestCI added a commit that referenced this issue Sep 20, 2018
@AutorestCI
[AutoPR datalake-analytics/data-plane] Add hierarchyQueueNode into Jo…
c3d12cf 
…bInformation(Basic) (#2734)

* Generated from af2b72334f7829e4d9c19f0fe66a255e74af10e6

Merge pull request #5 from hosunmsft/add_hq_node_to_adla_job_contract

add hierarchyQueueNode to JobInformation(Basic)

* Generated from 18f52ee03b87ca51b4b83de1d868a847771661fa

Tiny change to test github merge
jhendrixMSFT pushed a commit that referenced this issue Sep 20, 2018
@AutorestCI @jhendrixMSFT
[AutoPR datalake-analytics/data-plane] Add hierarchyQueueNode into Jo…
4c8866f 
…bInformation(Basic) (#2734)

* Generated from af2b72334f7829e4d9c19f0fe66a255e74af10e6

Merge pull request #5 from hosunmsft/add_hq_node_to_adla_job_contract

add hierarchyQueueNode to JobInformation(Basic)

* Generated from 18f52ee03b87ca51b4b83de1d868a847771661fa

Tiny change to test github merge
richardpark-msft pushed a commit to richardpark-msft/azure-sdk-for-go that referenced this issue Aug 5, 2021
@devigned
Merge pull request Azure#5 Claims-based Security using JWT
d50718b 
Claims-based Security using JWT
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevvooe @ahmetb @ruslangabitov