Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc clean-up reported by golangci-lint #10842

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Misc clean-up reported by golangci-lint #10842

merged 1 commit into from
Jun 26, 2020

Conversation

jhendrixMSFT
Copy link
Member

Only remaining issues is code in error.go.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • Apache v2 license headers are included in each file.

@jhendrixMSFT
Misc clean-up reported by golangci-lint
2859731 
Only remaining issues is code in error.go.
catalinaperalta
catalinaperalta approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhendrixMSFT jhendrixMSFT merged commit 0103ea6 into Azure:master Jun 26, 2020
@jhendrixMSFT jhendrixMSFT deleted the azcore_cleanup branch June 26, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinaperalta catalinaperalta catalinaperalta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhendrixMSFT @catalinaperalta