-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code tweaks: #15
Code tweaks: #15
Conversation
@jf your commit message is can you please:
otherwise lgtm. |
Thanks, @ahmetalpbalkan . This is a multi-line commit message, actually (and the process of submitting the PR only takes the first line). You can see the complete commit message at jf@b545204 |
I am aware but the first line should be descriptive enough. That's what appears in Commits list https://github.com/MSOpenTech/azure-sdk-for-go/commits/master Please refer to: |
ok, I see. |
ok I've tried to make the commit message as succinct, and yet as usefully descriptive as possible. Will this new one do? It's still not perfect (it seems that Github forcibly inserts a break at 72 chars?).... but I hope that this will work for you. |
sounds great, though, now you need to rebase because there are merge conflicts due to latest changes :)
|
…tring" parameter for the "Container" methods, plus fix some typos
Got it. The new code is in and rebased. |
Thanks @jf. Feel free to "watch" the repo to get notified about other changes. |
* Updating User Agent * Updating terminology in user agent. Now that storage is in its own repository, we don't need to continue tagging the data-plane that is being used. However, we still would like to bundle the targeted API Version into the User Agent field. This update would make that more clear.
* Updating User Agent * Updating terminology in user agent. Now that storage is in its own repository, we don't need to continue tagging the data-plane that is being used. However, we still would like to bundle the targeted API Version into the User Agent field. This update would make that more clear.
* Updating User Agent * Updating terminology in user agent. Now that storage is in its own repository, we don't need to continue tagging the data-plane that is being used. However, we still would like to bundle the targeted API Version into the User Agent field. This update would make that more clear.
Merge pull request #15 from moreOver0/yongw/fix fix cp field
start spans on entity new methods
Somewhat OCD, but I thought these would be good merged. Let me know what you think.