Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tables] connection string parser #15187
[Tables] connection string parser #15187
Changes from 5 commits
da7f308
4f2de5f
c94e1ce
bbe00cd
d967e57
c7da82f
4621f6c
ded6f8b
3842a4d
20ef734
0d28805
fdac8d6
95786a5
044733c
f405a90
99de9b0
f28e3f6
3f4cc57
2a3d5e5
48204fc
bb276fb
34871e6
cc7a769
7357bbf
1a40990
c88ae43
25fdd90
c41de6e
fbf1d9a
7c16a48
542360b
9a54e06
bb7978a
3e21e20
8194878
9c095bd
532c74e
caa14e8
ca09207
4125fd0
c125e2c
315a190
3b7e68d
8c9c9d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you can combine some of this and just set 'tableEndpoint' to either their custom one or the serviceURL you formed below (and return only once). Unless there's something else interesting you have planned where they'll diverge more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need tests for azurite connection strings also, since they do some different things with the account name.