feat: mgmt plane release tool update #16238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tadelesh
commented
Nov 22, 2021
•
tadelesh
commented
- The purpose of this PR is explained in this or a referenced issue.
- The PR does not update generated files.
- These files are managed by the codegen framework at Azure/autorest.go.
- Tests are included and/or updated for code changes.
- Updates to CHANGELOG.md are included.
- MIT license headers are included in each file.
- change second generate cmd to version replacement for update release
- refine changelog file content set based on new changelog format
- add refresh-v2 cmd for convenience
- add package config support for muliti-package rp onboard
…elog file content set based on new changelog format
| } | ||
|
|
||
| log.Printf("Release generation for rp: %s, namespace: %s", c.rpName, c.namespaceName) | ||
| generateCtx := common.GenerateContext{ | ||
| SDKPath: sdkRepo.Root(), | ||
| SDKRepo: &sdkRepo, | ||
| SDKPath: (*sdkRepo).Root(), |
There was a problem hiding this comment.
Why we have to dereference this variable? this looks weird
| commitIDRegex = regexp.MustCompile("^[0-9a-f]{40}$") | ||
| ) | ||
|
|
||
| func GetSDKRepo(sdkRepoParam, sdkRepoURL string) (*repo.SDKRepository, error) { |
There was a problem hiding this comment.
If I did not remember wrong, repo.SDKRepository is an interface, therefore we did not need to return pointer here
tadelesh
changed the title
ArcturusZhang
approved these changes
Nov 24, 2021
| @@ -9,4 +9,5 @@ require: | |||
| - https://github.com/Azure/azure-rest-api-specs/blob/{{commitID}}/specification/{{rpName}}/resource-manager/readme.go.md | |||
| license-header: MICROSOFT_MIT_NO_VERSION | |||
| module-version: 0.1.0 | |||
| {{packageConfig}} | |||
There was a problem hiding this comment.
I have added a config param to release-v2 for multi-package RP's onboard which can be used to add config like package-singleservers: true. Also, package config will be extracted from swagger config yaml annotation for SDK automation onboard.
jhendrixMSFT
pushed a commit
to jhendrixMSFT/azure-sdk-for-go
that referenced
this pull request
Jan 12, 2022
* feat: change second generate cmd to version replacement, refine changelog file content set based on new changelog format * feat: add refresh-v2 cmd * fix: add package config support for muliti-package rp onboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.