Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Functions managed identity test program #17104

Merged
merged 7 commits into from
Apr 19, 2022

Conversation

chlowell
Copy link
Member

For manual testing. Closes #12183

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run go - [service] - ci

@chlowell chlowell force-pushed the chlowell/functions-managed-id-test branch from e1af95b to c6f555d Compare February 23, 2022 16:51
@chlowell chlowell marked this pull request as ready for review February 23, 2022 17:08
Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great start. Are you planning on doing this automatically at some point as well?

@chlowell chlowell force-pushed the chlowell/functions-managed-id-test branch from e7c2ace to 3f37e28 Compare April 6, 2022 21:01
@RickWinter
Copy link
Member

@chlowell What is remaining on this PR to get it completed?

@chlowell
Copy link
Member Author

It's ready to merge. I've been holding off because a bicep file would be better than the markdown readme but haven't had the cycles to figure that out.

@chlowell
Copy link
Member Author

/check-enforcer override

@chlowell chlowell merged commit 5f1b3b9 into main Apr 19, 2022
@chlowell chlowell deleted the chlowell/functions-managed-id-test branch April 19, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Identity e2e tests for running in Azure Functions
3 participants