-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add auto release flag for mgmt. plane release #17356
Conversation
Looks good to me but holding approval until we reach a consensus on #17356 (comment) |
@seankane-msft could you have a review as I exclude the doc validation for the eng/tools folder? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, allowing Wes and Ben to make the final call
@benbp @weshaggard What does AutoRelease do? Does that mean a human never clicks the final approval? Do we have sufficient permissions and checks in place to prevent unintentional releases? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to ensure proper safeguards are in place to prevent unintentional triggers and resulting releases.
@RickWinter The word might be a little bit confusing. Actually |
8acbd91
to
fa48933
Compare
fa48933
to
ea36165
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. However I defer to @RickWinter on whether or not there are other considerations.
Resolve #17351