Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up in prep for merging feature/generics to main #17380

Merged
merged 3 commits into from
Mar 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions eng/pipelines/templates/jobs/archetype-sdk-client-samples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,10 @@ stages:
parameters:
AgentImage: $(image.name)

- template: /eng/pipelines/templates/steps/install-go-prerelease.yml
parameters:
archive: '$(go.archive)'
- task: GoTool@0
inputs:
version: '$(go.version)'
displayName: "Select Go Version"

- template: ../steps/create-go-workspace.yml

Expand Down
7 changes: 4 additions & 3 deletions eng/pipelines/templates/jobs/archetype-sdk-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,10 @@ stages:
parameters:
AgentImage: $(image.name)

- template: /eng/pipelines/templates/steps/install-go-prerelease.yml
parameters:
archive: '$(go.archive)'
- task: GoTool@0
inputs:
version: '$(go.version)'
displayName: "Select Go Version"

- template: ../steps/create-go-workspace.yml

Expand Down
2 changes: 0 additions & 2 deletions eng/pipelines/templates/steps/analyze.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ steps:
golangci-lint --version
displayName: 'Install GoLintCLI and dependencies.'
workingDirectory: $(System.DefaultWorkingDirectory)
continueOnError: true

- pwsh: |
$modDirs = ./eng/scripts/get_module_dirs.ps1 '${{ parameters.ServiceDirectory }}'
Expand All @@ -36,7 +35,6 @@ steps:
displayName: 'Lint'
failOnStderr: false
workingDirectory: $(System.DefaultWorkingDirectory)
continueOnError: true

- pwsh: |
$modDirs = ./eng/scripts/get_module_dirs.ps1 '${{ parameters.ServiceDirectory }}'
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/templates/steps/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ steps:

- pwsh: |
go install github.com/jstemmer/go-junit-report@v0.9.1
go install github.com/axw/gocov/gocov@v1.0.0
go install github.com/jhendrixMSFT/gocov/gocov@v1.0.1-0.20220325195445-df8497555dba
go install github.com/AlekSi/gocov-xml@v1.0.0
go install github.com/matm/gocov-html@v0.0.0-20200509184451-71874e2e203b
displayName: "Install Coverage and Junit Dependencies"
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/templates/variables/globals.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
variables:
GoLintCLIVersion: 'v1.45.0'
GoLintCLIVersion: 'v1.45.2'
Package.EnableSBOMSigning: true
2 changes: 1 addition & 1 deletion eng/scripts/MgmtTestLib.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ function TestAndGenerateReport($dir)
Set-Location $dir
# dependencies for go coverage report generation
go get github.com/jstemmer/go-junit-report
go get github.com/axw/gocov/gocov
go get github.com/jhendrixMSFT/gocov/gocov
go get github.com/AlekSi/gocov-xml
go get github.com/matm/gocov-html

Expand Down
1 change: 0 additions & 1 deletion eng/scripts/run_tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ go test -timeout $testTimeout -v -coverprofile coverage.txt ./... | Tee-Object -
if ($LASTEXITCODE) {
exit $LASTEXITCODE
}
exit 0

Get-Content outfile.txt | go-junit-report > report.xml

Expand Down
8 changes: 6 additions & 2 deletions sdk/azcore/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
# Release History

## 0.22.1 (Unreleased)
## 0.23.0 (Unreleased)

### Features Added
* Added `runtime.Pager[T any]` and supporting types for a central, generic, pager implementation.
* Added `runtime.Pager[T any]` and `runtime.Poller[T any]` supporting types for central, generic, implementations.

### Breaking Changes
* Removed the `Poller` type-alias to the internal poller implementation.
* Added `Ptr[T any]` and `SliceOfPtrs[T any]` in the `to` package and removed all non-generic implementations.
* `NullValue` and `IsNullValue` now take a generic type parameter instead of an interface func parameter.

### Bugs Fixed

### Other Changes
* Converted expiring resource and dependent types to use generics.

## 0.22.0 (2022-03-03)

Expand Down
2 changes: 1 addition & 1 deletion sdk/azcore/internal/shared/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ const (
Module = "azcore"

// Version is the semantic version (see http://semver.org) of this module.
Version = "v0.22.1"
Version = "v0.23.0"
)