Add Vip addresses & InstanceEndpoints to VMs #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -171,6 +186,14 @@ type RoleSize struct { | |||
| VirtualMachineResourceDiskSizeInMb int | |||
| } | |||
|
|
|||
| type VirtualIPs struct { | |||
| VirtualIP []*VirtualIP | |||
There was a problem hiding this comment.
Thanks ... removed.
|
@keithchambers please squash the additional fixes into one commit (in this case your initial commit) and cc: @hopetobelievein @paulmey @jeffmendoza for review |
Credit to @frodenas for inspiration.
|
Thank you Ahmet. I have now squashed the commits and pushed to my branch. |
|
Looks good |
|
Lgtm as well |
jeffmendoza
pushed a commit
that referenced
this pull request
Jan 29, 2015
Add Vip addresses & InstanceEndpoints to VMs
richardpark-msft
pushed a commit
to richardpark-msft/azure-sdk-for-go
that referenced
this pull request
Aug 5, 2021
add travis integration build and badges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to @frodenas for inspiration.
CLA has been signed.