Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent azkeys tests incorrectly targeting MHSM #18318

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

chlowell
Copy link
Member

@chlowell chlowell commented Jun 6, 2022

azkeys test runs have been timing out because one test case doesn't skip its MHSM subtest when lacking MHSM configuration. This PR moves the MHSM check into the helper function that initializes recording, ensuring all recorded tests execute it.

@chlowell chlowell added KeyVault Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable labels Jun 6, 2022
@chlowell chlowell requested a review from jhendrixMSFT as a code owner June 6, 2022 16:50
@chlowell chlowell merged commit 30ff870 into main Jun 6, 2022
@chlowell chlowell deleted the chlowell/fix-immutable-test branch June 6, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-reliability Issue that causes tests to be unreliable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants