Add support for making recordings external to the repository

[benbp]

Fixes Azure/azure-sdk-tools#4257

This adds support to the recording package to work with test proxy asset sync, which will allow the test recordings to be moved out of the go repository into https://github.com/Azure/azure-sdk-assets.

The primary behavior change is: if an assets.json file is found in the current test service directory or any parent, the recording framework will request external assets via the test proxy during test setup. If there is no assets.json, then pre-existing recordings will be used instead. This change should support running tests via run_tests.ps1 or invoking go test directly.

I also added some minor improvements to the testing scripts.

• Improve error and pipeline handling in run_tests.ps1
• Add test proxy default assets directory to gitignore
• Support test proxy external asset mode for test recordings

[benbp]

Looks like windows tests are failing due to some path handling differences with the OS. Investigating...

[benbp]

@jhendrixMSFT @richardpark-msft do you anticipate a future requirement to define configs for recording assets in directories below the service directory (e.g. deeper than sdk/keyvault/azkeys)? That is to say, will we need more granularity with recordings than the main package? I've skipped that functionality for now assuming it won't be needed.

[jhendrixMSFT]

In azblob there are tests in subdirectories. Does this mean the feature is required?

[benbp]

In azblob there are tests in subdirectories. Does this mean the feature is required?

It's a weird scenario I'm thinking of where you would have tests in a sub-directory, and an asset configuration for those test recordings in the sub-directory, but you invoke the tests from a parent directory (either with ./... or like ./container/...). Let me dig back into it.

[jhendrixMSFT]

We definitely need go test ./... from the azblob directory to work.

[benbp]

Alright, the latest update is much more flexible with the working directory of go test and the asset config path relative to the recording directory (anywhere at or above), as well as fixing some windows file and root detection issues. It does require that tests be run from within a git repository, i.e. this won't work if you have downloaded the repo code without .git, but I don't anticipate this will be an issue.

[scbedd]

This looks great. Thank you so much @benbp

[benbp]

/azp run go - internal - ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).