[azservicebus] Removing the idle tracking code. #19581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendrixMSFT
approved these changes
Nov 16, 2022
|
/azp run go - azservicebus |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…imeout - together they're creating a perfect storm for customers and causing hangs. I also left in the removal of the defaultDrainTimeout private field - it's not used at all.
richardpark-msft
force-pushed
the
sb-rollback-keepalive
branch
from
afa4aea to
b2f34e7
Compare
|
/azp run go - azservicebus |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jhendrixMSFT
approved these changes
Nov 17, 2022
|
I want to say the 1.1.2 makes our service down because this issue. Besides this fix, could you try to avoid using a path release for these big changes? |
Hi @yulin-li, you've got a good point about this change, although it was intended to simply complement the existing recovery code (but revealed a weak point). The next time I release this it'll go out as a minor rev bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client-side idle tracking was added in v1.1.2, but it seems be causing issues for customers and is actually making their receiving less reliable. I had previously removed it for just sessions, but I'm now also removing it for non-session receivers as well.
I'm leaving the idle check code, just not hooked up for now, because it still seems like a good defensive feature but it requires more testing and stressing to be fit for production.
This rolls back the changes in #19465 (simple idle timer), #19492 (ignore ctx on link close) and #19506 (track idle across multiple receives).