[Release] sdk/resourcemanager/orbital/armorbital/2.0.0

[azure-sdk]

https://github.com/Azure/sdk-release-request/issues/3878

[RickWinter]

@JeffreyRichter , @jhendrixMSFT Please review the breaking changes causing major version bumps. Major bumps are painful and doing them because something was removed feels icky. Could we find ways to deprecate via README.md directives?

[JeffreyRichter]

Deprecating doesn't help the customer. They still must change their code. We just have to accept that this is the way it is. I get that it's not ideal.

…

-- Jeffrey

________________________________ From: Rick Winter ***@***.***> Sent: Friday, March 10, 2023 8:34:23 AM To: Azure/azure-sdk-for-go ***@***.***> Cc: Jeffrey Richter ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/azure-sdk-for-go] [Release] sdk/resourcemanager/orbital/armorbital/2.0.0 (PR #20365) @RickWinter requested changes on this pull request. @JeffreyRichter<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeffreyRichter&data=05%7C01%7Cjeffreyr%40microsoft.com%7C6c8a565a0de3454b605b08db21854ef4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638140628666087793%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JmIyFBHYIPcpjxV6DHMFBJjCxHhzcR19jblkBewfJdg%3D&reserved=0> , @jhendrixMSFT<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FjhendrixMSFT&data=05%7C01%7Cjeffreyr%40microsoft.com%7C6c8a565a0de3454b605b08db21854ef4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638140628666087793%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=at3pcYOkpBO08vXhg7C578YphBtCTZhtJYcqZwGTfuw%3D&reserved=0> Please review the breaking changes causing major version bumps. Major bumps are painful and doing them because something was removed feels icky. Could we find ways to deprecate via README.md directives? — Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-go%2Fpull%2F20365%23pullrequestreview-1335189222&data=05%7C01%7Cjeffreyr%40microsoft.com%7C6c8a565a0de3454b605b08db21854ef4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638140628666087793%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=owsgEQBv121pfQ6cTdzWA4lj1%2ByfZr3hXusZwJNXtSU%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAARLJP3MXQIP6ZJMYB5XKK3W3NJY7ANCNFSM6AAAAAAVTFRPZE&data=05%7C01%7Cjeffreyr%40microsoft.com%7C6c8a565a0de3454b605b08db21854ef4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638140628666087793%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RiJxbpJtZMovacdwZKaNEKzRz0O5n8jXiU05eT2O7io%3D&reserved=0>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[RickWinter]

Deprecating helps if they aren't using the type which could be very likely.

[JeffreyRichter]

Then they can also stay on the current version.

…

-- Jeffrey

________________________________ From: Rick Winter ***@***.***> Sent: Friday, March 10, 2023 9:34:31 AM To: Azure/azure-sdk-for-go ***@***.***> Cc: Jeffrey Richter ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/azure-sdk-for-go] [Release] sdk/resourcemanager/orbital/armorbital/2.0.0 (PR #20365) Deprecating helps if they aren't using the type which could be very likely. — Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-go%2Fpull%2F20365%23issuecomment-1464139605&data=05%7C01%7Cjeffreyr%40microsoft.com%7Ca64847b85ba74a38845308db218db545%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638140664742520849%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WY7lzkuk938RXZ1Os6dw%2F2cnOny08vagaExUD31216g%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAARLJP2ZJTD7IKPLX7I2YQDW3NQ2PANCNFSM6AAAAAAVTFRPZE&data=05%7C01%7Cjeffreyr%40microsoft.com%7Ca64847b85ba74a38845308db218db545%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638140664742520849%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=mD5070GGAtGWoYYy4a77T9G2EgkuX5kzSdaaymMquZ0%3D&reserved=0>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[RickWinter]

Agreed, Only true when they don't want any of the new features.

[JeffreyRichter]

Joel will have to comment on how Deprecated could be emitted by the generator. Some examples: https://cs.opensource.google/search?q=Deprecated:%20language:go&ss=go%2Fgo

…

-- Jeffrey

________________________________ From: Rick Winter ***@***.***> Sent: Friday, March 10, 2023 9:38:05 AM To: Azure/azure-sdk-for-go ***@***.***> Cc: Jeffrey Richter ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/azure-sdk-for-go] [Release] sdk/resourcemanager/orbital/armorbital/2.0.0 (PR #20365) Agreed, Only true when they don't want any of the new features. — Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-go%2Fpull%2F20365%23issuecomment-1464143910&data=05%7C01%7Cjeffreyr%40microsoft.com%7Cbdbf6378aa12417b45bf08db218e34f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638140666885586181%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=M9nt9OcB5bYNFh%2BWyMiQn1xADFgQF9SiXW%2F39LKxcR0%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAARLJP3NLX26WJDBJSRD2RTW3NRH3ANCNFSM6AAAAAAVTFRPZE&data=05%7C01%7Cjeffreyr%40microsoft.com%7Cbdbf6378aa12417b45bf08db218e34f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638140666885586181%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LKLnZ647k3dRBEw7QcPsMRrwSDTpqK6php7qZr6oU0U%3D&reserved=0>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[jhendrixMSFT]

For cases where something has been removed, it's not simply a matter of emitting a // Deprecated doc comment during code generation. In order to know that something has been removed, we'd need to compare the current version against the previous version. This can get especially tricky to automate for cases where something wasn't removed but was renamed.

[tadelesh]

For cases where something has been removed, it's not simply a matter of emitting a // Deprecated doc comment during code generation. In order to know that something has been removed, we'd need to compare the current version against the previous version. This can get especially tricky to automate for cases where something wasn't removed but was renamed.

I agree. Since swagger does not provide deprecation feature, we could not auto-generate the deprecation part correctly. I don't believe manual maintenance is practical.

[tadelesh]

The breaking changes are introduced and approved in this swagger PR. @JeffreyRichter could you please approve this major version release with adding Approved Major Version label?

Jeff has approved the major version.