BlockBlob Client: Transactional/Source Content Validation #20666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
siminsavani-msft
commented
Apr 19, 2023
•
siminsavani-msft
commented
- StageBlock
- Recorded existing SDK generated CRC64 test
- Added and recorded positive and negative user generated CRC64
- Positive and negative user generated MD5 test exist (minor cleanup)
- TODO: Record these tests
- StageBlockFromURL
- Added test for positive and negative user generated MD5
- Added test for positive and negative user generated CRC64
- CommitBlockList
- Deprecated TransactionalContentCRC64
- Deprecated TransactionContentMD5
- Context: CommitBlockList works at block level and overall checksums cannot be generated at block level.
- TODO: Do we want to throw error when users add these options?
- CopyFromURL
- Added positive and negative user generated MD5 test from blob + minor changes
- UploadBuffer
- Added major changes here TODO: regenerate as needed
- The purpose of this PR is explained in this or a referenced issue.
- The PR does not update generated files.
- These files are managed by the codegen framework at Azure/autorest.go.
- Tests are included and/or updated for code changes.
- Updates to CHANGELOG.md are included.
- MIT license headers are included in each file.
|
Closing PR and reopening new PR here: #20666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.