Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azfile: upgrade to STG 87 #20871

Merged
merged 13 commits into from
Jun 15, 2023
Merged

azfile: upgrade to STG 87 #20871

merged 13 commits into from
Jun 15, 2023

Conversation

souravgupta-msft
Copy link
Member

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@souravgupta-msft souravgupta-msft added Storage Storage Service (Queues, Blobs, Files) AzFile labels May 18, 2023
@souravgupta-msft souravgupta-msft added this to the azfile v0.1.1 milestone May 18, 2023
@souravgupta-msft
Copy link
Member Author

/azp run go - azfile

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@souravgupta-msft
Copy link
Member Author

/azp run go - azfile

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jhendrixMSFT
jhendrixMSFT requested changes Jun 5, 2023
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since an *azcore.Client contains instance-specific data, we cannot reuse them for "child" clients.

jhendrixMSFT
jhendrixMSFT requested changes Jun 5, 2023
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since an *azcore.Client contains instance-specific data, we cannot reuse them for "child" clients.

jhendrixMSFT
jhendrixMSFT requested changes Jun 5, 2023
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since an *azcore.Client contains instance-specific data, we cannot reuse them for "child" clients.

@souravgupta-msft
Copy link
Member Author

/azp run go - azfile

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@souravgupta-msft
Copy link
Member Author

/azp run go - azfile

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@souravgupta-msft
Copy link
Member Author

/azp run go - azfile

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@souravgupta-msft souravgupta-msft merged commit 4b1106a into Azure:feature/azfile Jun 15, 2023
@souravgupta-msft souravgupta-msft deleted the sourav/stg87 branch June 15, 2023 05:11
souravgupta-msft added a commit to souravgupta-msft/azure-sdk-for-go that referenced this pull request Jul 19, 2023
@souravgupta-msft
azfile: upgrade to STG 87 (Azure#20871)
9aca0a7
souravgupta-msft added a commit that referenced this pull request Jul 20, 2023
@souravgupta-msft
azfile: sync with main (#21216)
97e0693 
* azfile: upgrade to STG 87 (#20871)

* azfile: OAuth support (#21088)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova left review comments

@siminsavani-msft siminsavani-msft siminsavani-msft approved these changes

@gapra-msft gapra-msft gapra-msft approved these changes

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@tasherif-msft tasherif-msft Awaiting requested review from tasherif-msft

@vibhansa-msft vibhansa-msft Awaiting requested review from vibhansa-msft vibhansa-msft is a code owner

Assignees
No one assigned
Labels
AzFile Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
azfile v1.1.0-beta.1
Development

Successfully merging this pull request may close these issues.
5 participants
@souravgupta-msft @lmolkova @jhendrixMSFT @gapra-msft @siminsavani-msft