Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyvault] prep-for-release #20991

Merged
merged 1 commit into from
Jun 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/security/keyvault/azadmin/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Release History

## 0.3.0 (2023-06-06)
## 0.3.0 (2023-06-08)

### Breatking Changes
* Renamed `SASTokenParameter` to `SASTokenParameters`
Expand Down
3 changes: 2 additions & 1 deletion sdk/security/keyvault/azkeys/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Release History

## 0.12.0 (unreleased)
## 0.12.0 (2023-06-08)

### Breaking Changes

Expand All @@ -24,6 +24,7 @@
* `JSONWebKeyEncryptionAlgorithm` to `EncryptionAlgorithm`
* `JSONWebKeySignatureAlgorithm` to `SignatureAlgorithm`
* `JSONWebKeyType` to `KeyType`
* `LifetimeActions` to `LifetimeAction`
* Removed `DeletionRecoveryLevel` type
* Removed `SignatureAlgorithmRSNULL` constant
* Removed `KeyOperationExport` constant
Expand Down
11 changes: 11 additions & 0 deletions sdk/security/keyvault/azkeys/autorest.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,17 @@ directive:
where: $.definitions.RestoreKeyParameters.properties.value
transform: $["x-ms-client-name"] = "KeyBackup"

# Change LifetimeActions to LifetimeAction
- rename-model:
from: LifetimeActions
to: LifetimeAction
- rename-model:
from: LifetimeActionsType
to: LifetimeActionType
- rename-model:
from: LifetimeActionsTrigger
to: LifetimeActionTrigger

# Remove MaxResults parameter
- where: "$.paths..*"
remove-parameter:
Expand Down
6 changes: 3 additions & 3 deletions sdk/security/keyvault/azkeys/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -620,12 +620,12 @@ func TestRotateKey(t *testing.T) {
Attributes: &azkeys.KeyRotationPolicyAttributes{
ExpiryTime: to.Ptr("P90D"),
},
LifetimeActions: []*azkeys.LifetimeActions{
LifetimeActions: []*azkeys.LifetimeAction{
{
Action: &azkeys.LifetimeActionsType{
Action: &azkeys.LifetimeActionType{
Type: to.Ptr(azkeys.KeyRotationPolicyActionRotate),
},
Trigger: &azkeys.LifetimeActionsTrigger{
Trigger: &azkeys.LifetimeActionTrigger{
TimeAfterCreate: timeAfterCreate,
},
},
Expand Down
6 changes: 3 additions & 3 deletions sdk/security/keyvault/azkeys/example_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,12 @@ func ExampleClient_UpdateKey() {
func ExampleClient_UpdateKeyRotationPolicy() {
// this policy rotates the key every 18 months
policy := azkeys.KeyRotationPolicy{
LifetimeActions: []*azkeys.LifetimeActions{
LifetimeActions: []*azkeys.LifetimeAction{
{
Action: &azkeys.LifetimeActionsType{
Action: &azkeys.LifetimeActionType{
Type: to.Ptr(azkeys.KeyRotationPolicyActionRotate),
},
Trigger: &azkeys.LifetimeActionsTrigger{
Trigger: &azkeys.LifetimeActionTrigger{
TimeAfterCreate: to.Ptr("P18M"),
},
},
Expand Down
18 changes: 9 additions & 9 deletions sdk/security/keyvault/azkeys/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions sdk/security/keyvault/azkeys/models_serde.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/security/keyvault/azsecrets/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Release History

## 0.14.0 (2023-06-06)
## 0.14.0 (2023-06-08)

### Breaking Changes
* Renamed `Client.ListSecrets` to `Client.ListSecretProperties`
Expand Down