-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature STG 85/86] Cold Tier #21024
Closed
siminsavani-msft
wants to merge
29
commits into
Azure:feature/azblob-stg85/86
from
siminsavani-msft:cold-tier
Closed
[Feature STG 85/86] Cold Tier #21024
siminsavani-msft
wants to merge
29
commits into
Azure:feature/azblob-stg85/86
from
siminsavani-msft:cold-tier
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
siminsavani-msft
commented
Jun 15, 2023
•
edited
Loading
edited
- Added AccessTierCold to constants.go in blob
- Added tests or updated tests for the following APIs:
- Container - Flat List Blob, Hierarchy List Blobs
- BlockBlob - Upload(), UploadBlobFromURL/PutBlobFromURL(), CommitBlockList()
- Blob - SetTier(), GetPropertiest(), CopyFromURL(), StartCopyFromURL()
- The purpose of this PR is explained in this or a referenced issue.
- The PR does not update generated files.
- These files are managed by the codegen framework at Azure/autorest.go.
- Tests are included and/or updated for code changes.
- Updates to CHANGELOG.md are included.
- MIT license headers are included in each file.
siminsavani-msft
requested review from
souravgupta-msft,
tasherif-msft,
jhendrixMSFT,
gapra-msft and
vibhansa-msft
as code owners
June 19, 2023 16:12
/azp run go - azblob |
Azure Pipelines successfully started running 1 pipeline(s). |
New PR here: #21032 |
gapra-msft
reviewed
Jun 19, 2023
@@ -3,6 +3,7 @@ | |||
## 1.1.0-beta.2 (Unreleased) | |||
|
|||
### Features Added | |||
* Added `AccessTierCold`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added support for Cold tier.
gapra-msft
reviewed
Jun 19, 2023
//// testcommon.ValidateBlobErrorCode(c, err, bloberror.InvalidHeaderValue) | ||
////} | ||
//// | ||
// //func (s *BlobRecordedTestsSuite) TestBlobTierInferred() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this test commented out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.