Update CODEOWNERS for Identity #21247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
requested review from
benbp,
jsquire,
jhendrixMSFT,
RickWinter and
ronniegeraghty
as code owners
| @@ -16,7 +16,7 @@ | |||
| /sdk/azcore/ @rickwinter @chlowell @jhendrixMSFT @richardpark-msft | |||
|
|
|||
| # PRLabel: %Azure.Identity | |||
| /sdk/azidentity/ @chlowell @jhendrixMSFT @rickwinter | |||
| /sdk/azidentity/ @chlowell @jhendrixMSFT @rickwinter @Azure/azsdk-identity | |||
There was a problem hiding this comment.
This addition is being flagged as an error. Does this team exist?
There was a problem hiding this comment.
I think it may be missing a couple of the access requirements we have in our automation (Azure/azure-sdk-tools#4487 (comment)). We will be trying to set that up this week.
There was a problem hiding this comment.
The team exists and is publicly visible, so I guess it lacks write access to the repo. Following Jim's comment, I suppose the solution is to make Azure/azsdk-identity a member of azure-sdk-write. Do you know who's able to do that?
|
Superseded by #21366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.