Add KeyCredential and SASCredential types #21553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes supporting pipeline policies, config options, etc.
|
Still need to add tests (this is why the CI fails). |
jhendrixMSFT
requested review from
RickWinter,
chlowell and
richardpark-msft
as code owners
jhendrixMSFT
commented
Sep 13, 2023
chlowell
reviewed
Sep 14, 2023
richardpark-msft
requested changes
Sep 14, 2023
richardpark-msft
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Looks fine by me, @chlowell has a few unresolved questions, I believe, although I think we were just waiting for @JeffreyRichter to weigh in.
|
@chlowell any other concerns? @JeffreyRichter does this look good now? |
JeffreyRichter
approved these changes
Sep 15, 2023
chlowell
approved these changes
Sep 15, 2023
jhendrixMSFT
added a commit
to jhendrixMSFT/azure-sdk-for-go
that referenced
this pull request
Oct 5, 2023
Includes supporting pipeline policies, config options, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes supporting pipeline policies, config options, etc.
Fixes #20541