Azcore v1.8.0 #21694

jhendrixMSFT · 2023-10-05T16:09:15Z

This contains the following cherry-picks.

4a66b4f
5624b2d
f839de4
9b73d1f
f6a43aa
f9574cd
96a6b85
081c5e3
cd1cd87
5d04047
0e74539
8db55a4
10f029c
81c4f03

…ec commit: 310a0100f5b020c1900c527a6aa70d21992f078a (Azure#21111)

* [Release] sdk/resourcemanager/network/armnetwork/4.0.0 generation from spec commit: 9975d3476c05bcc6bd9535ad3dfb564e6a168fa5 * replace stable azcore * update live test and assets

…zure#21136) * [Release] sdk/resourcemanager/mobilenetwork/armmobilenetwork/3.0.0 generation from spec commit: c53808ba54beef57059371708f1fa6949a11a280 * regenerate

…stotz89

…stotz89 (Azure#21230) * [azblob][sas] Fix SignWithSharedKey if stored access policy is used * Adding test and changelog --------- Co-authored-by: Sourav Gupta <souravgupta@microsoft.com>

…penai` (Azure#21264) Part of the fix for Azure#21260. - Moved the code (to preserve history) into `ai/azopenai` - Marked `cognitiveservices/azopenai`, prepping to release one last release to deprecate it. We still need to submit an issue to de-list `cognitiveservices/azopenai` but I believe this takes care of our end.

…Azure#21269)

Regexp checks for major, minor and patch level, but fails with golang release candidate versions, as doesn't match regexp. Example: azsdk-go-azservicebus/v1.0.0 (go1.21rc3; linux)

* fixed string to sign issue * fixed test and added changelog

…zure#21168) * Auto-install and run standalone test proxy server per test package * Update recording tests to use standalone proxy * Simplify proxy binary switch statement * Add test proxy auto-install docs * Fix up recording test coverage * Add StopTestProxy note about go process handling * Proxy restore/race condition handling. Force ignore PROXY_MANUAL_START in internal tests * Fix recording readme error handling

…1265) * sdk/resourcemanager/network/armnetwork/4.1.0-beta.1 * add fake_example_test.go

…2.0-beta.1 (Azure#21274)

…21275) * [Release] sdk/resourcemanager/compute/armcompute/5.2.0-beta.1 * Update CHANGELOG.md

* [Release] sdk/resourcemanager/sql/armsql/2.0.0-beta.1 generation from spec commit: fba7ffa9cee6453e2a3cf8c857074a323252a12d * update release date * regenerated * regenerate

… Azure OpenAI packages (Azure#21284)

* Clean up constants in aztables Older versions of autorest implicitly sealed single-value enums, so enable the legacy behavior to avoid having to pass constant values. Updated the perf test to use the current version of aztables. * update perf test with renamed APIs

Adds in a ci.yml with live testing enabled and re-recordings since we moved to `ai` instead of `cognitiveservices`.

* Bump test proxy version * move proxy transition-scripts folder to onboarding Co-authored-by: Bill Wert <billwert@microsoft.com> Co-authored-by: Scott Beddall <scbedd@microsoft.com>

…zure#21282) * azcore: Removing the json.RawMessage dependency in the public API (it wasn't part of the signature (formally) but it was part of the returned type. * Consume new pre-release azcore in azeventgrid.

* update dotnet dev cert being shipped with the proxy to renew for another year --------- Co-authored-by: Scott Beddall <scbedd@microsoft.com>

* Improve example for runtime.WithCaptureResponse * make linter happy * fix sentence

Return the result of reader.Close() to the caller.

…zure#21312)

* add replaceFakeImport function * generic func * remove breakingchange judgment * fix

sdk/azcore/CHANGELOG.md

RickWinter

Has the surface area additions been approved by Jeff?

sdk/azcore/arm/runtime/policy_register_rp.go

sdk/azcore/messaging/cloud_event.go

jhendrixMSFT · 2023-10-05T16:32:35Z

The public surface area additions have been approved in their constituent PRs but will require a formal approval in APIView before we can release.

CC @JeffreyRichter

jhendrixMSFT · 2023-10-05T16:47:12Z

/azp run

azure-pipelines · 2023-10-05T16:47:18Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

jhendrixMSFT · 2023-10-05T16:47:33Z

/azp run go - azcore

azure-pipelines · 2023-10-05T16:47:43Z

Azure Pipelines failed to run 1 pipeline(s).

jhendrixMSFT · 2023-10-05T18:02:06Z

@benbp are there other commits I should cherry-pick into this branch to get CI working?

sdk/azcore/CHANGELOG.md

benbp · 2023-10-05T18:15:19Z

@jhendrixMSFT at the very least, these three from https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/740/Breaking-Changes

9401c5e
e9c77a5
d0dc9e9

But it might be better, if possible, to pull in the entire eng directory from main instead.

jhendrixMSFT · 2023-10-05T18:17:46Z

@benbp is there an easy way for me to pull in all of eng from main?

benbp · 2023-10-05T18:44:23Z

@jhendrixMSFT I think something like this will work. Replace origin with whatever your upstream remote is named.

git fetch --all
git merge --allow-unrelated-histories -s ours --no-commit origin/main
git rm -r eng/
git read-tree --prefix=eng/ -u origin/main:eng
git commit -m 'Merge eng from main'

jhendrixMSFT · 2023-10-05T19:15:45Z

@benbp it's working now, thanks so much for the help.

benbp · 2023-10-05T19:16:23Z

Awesome!

jhendrixMSFT · 2023-10-05T19:19:22Z

#21116 strikes again

Alancere and others added 30 commits July 26, 2023 10:49

[Release] sdk/resourcemanager/batch/armbatch/2.0.0 generation from sp…

24752d8

…ec commit: 310a0100f5b020c1900c527a6aa70d21992f078a (Azure#21111)

[Release] sdk/resourcemanager/network/armnetwork/4.0.0 (Azure#21131)

b609b0a

* [Release] sdk/resourcemanager/network/armnetwork/4.0.0 generation from spec commit: 9975d3476c05bcc6bd9535ad3dfb564e6a168fa5 * replace stable azcore * update live test and assets

[Release] sdk/resourcemanager/mobilenetwork/armmobilenetwork/3.0.0 (A…

62fe6f8

…zure#21136) * [Release] sdk/resourcemanager/mobilenetwork/armmobilenetwork/3.0.0 generation from spec commit: c53808ba54beef57059371708f1fa6949a11a280 * regenerate

SAS creation fix when stored access policy is used (Azure#21241)

afa59e5

[azblob][sas] Fix SignWithSharedKey if stored access policy is used @…

a4e1833

…stotz89 (Azure#21230) * [azblob][sas] Fix SignWithSharedKey if stored access policy is used * Adding test and changelog --------- Co-authored-by: Sourav Gupta <souravgupta@microsoft.com>

Update legacy azopenai yaml to add cognitiveservices suffix directive (…

31f4b23

…Azure#21269)

[azopenai] Update changelog to reflect new spot. (Azure#21271)

613d6a2

Increment package version after release of ai/azopenai (Azure#21272)

53a0a41

[internal] Extend telemetry test regexp (Azure#21277)

567ea3e

Regexp checks for major, minor and patch level, but fails with golang release candidate versions, as doesn't match regexp. Example: azsdk-go-azservicebus/v1.0.0 (go1.21rc3; linux)

[Storage] Lower Case Query Param Keys in String to Sign (Azure#21262)

c83d84e

* fixed string to sign issue * fixed test and added changelog

[Release]sdk/resourcemanager/network/armnetwork/4.1.0-beta.1 (Azure#2…

02e688d

…1265) * sdk/resourcemanager/network/armnetwork/4.1.0-beta.1 * add fake_example_test.go

[Release] sdk/resourcemanager/containerservice/armcontainerservice/4.…

14c29ba

…2.0-beta.1 (Azure#21274)

[Release] sdk/resourcemanager/compute/armcompute/5.2.0-beta.1 (Azure#…

e20e260

…21275) * [Release] sdk/resourcemanager/compute/armcompute/5.2.0-beta.1 * Update CHANGELOG.md

[Release] sdk/resourcemanager/sql/armsql/2.0.0-beta.1 (Azure#21040)

eb1708f

* [Release] sdk/resourcemanager/sql/armsql/2.0.0-beta.1 generation from spec commit: fba7ffa9cee6453e2a3cf8c857074a323252a12d * update release date * regenerated * regenerate

[azopenai] Rename the DeploymentID field to Deployment to match other…

0b38572

… Azure OpenAI packages (Azure#21284)

[azopenai] Enabling live testing (Azure#21276)

91847b5

Adds in a ci.yml with live testing enabled and re-recordings since we moved to `ai` instead of `cognitiveservices`.

Make recording.proxyManualStartEnv private (Azure#21288)

b8af6dd

Sync eng/common directory with azure-sdk-tools for PR 6518 (Azure#21200)

f0e9d49

* Bump test proxy version * move proxy transition-scripts folder to onboarding Co-authored-by: Bill Wert <billwert@microsoft.com> Co-authored-by: Scott Beddall <scbedd@microsoft.com>

upgrade autorest extension version (Azure#21293)

054fcba

Sync eng/common directory with azure-sdk-tools for PR 6611 (Azure#21295)

c606534

* update dotnet dev cert being shipped with the proxy to renew for another year --------- Co-authored-by: Scott Beddall <scbedd@microsoft.com>

Improve example for runtime.WithCaptureResponse (Azure#21302)

9b73d1f

* Improve example for runtime.WithCaptureResponse * make linter happy * fix sentence

Don't swallow error on Close() (Azure#21304)

4766d8b

Return the result of reader.Close() to the caller.

update azadmin test (Azure#21305)

6e977ba

[azopenai] Make sure we defer close the eventreader in our examples. (A…

4060121

…zure#21312)

prep for release (Azure#21316)

90bbc9e

Major version upgrade when processing fake (Azure#21285)

00e9b6c

* add replaceFakeImport function * generic func * remove breakingchange judgment * fix

jhendrixMSFT requested review from benbp, weshaggard, RickWinter, chlowell and richardpark-msft as code owners October 5, 2023 16:09

github-actions bot added the Azure.Core label Oct 5, 2023

jhendrixMSFT commented Oct 5, 2023

View reviewed changes

sdk/azcore/CHANGELOG.md Outdated Show resolved Hide resolved

RickWinter reviewed Oct 5, 2023

View reviewed changes

sdk/azcore/arm/runtime/policy_register_rp.go Show resolved Hide resolved

sdk/azcore/messaging/cloud_event.go Outdated Show resolved Hide resolved

chlowell approved these changes Oct 5, 2023

View reviewed changes

jhendrixMSFT added 3 commits October 5, 2023 10:57

Fix MIT license comment (Azure#21695)

985c875

Fix MIT license comment (Azure#21695)

83a127e

add missing changelog entries for CAE

50aae73

chlowell reviewed Oct 5, 2023

View reviewed changes

sdk/azcore/CHANGELOG.md Outdated Show resolved Hide resolved

additional changelog cleanup

034d523

jhendrixMSFT added 2 commits October 5, 2023 12:06

added missing changelong entry

9dee085

merge eng from main

082725d

jhendrixMSFT merged commit 112db83 into Azure:release/azcore-v1.8.0 Oct 5, 2023
38 of 50 checks passed

jhendrixMSFT deleted the azcore-v1.8.0 branch October 5, 2023 19:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azcore v1.8.0 #21694

Azcore v1.8.0 #21694

jhendrixMSFT commented Oct 5, 2023

RickWinter left a comment

jhendrixMSFT commented Oct 5, 2023

jhendrixMSFT commented Oct 5, 2023

azure-pipelines bot commented Oct 5, 2023

jhendrixMSFT commented Oct 5, 2023

azure-pipelines bot commented Oct 5, 2023

jhendrixMSFT commented Oct 5, 2023

benbp commented Oct 5, 2023

jhendrixMSFT commented Oct 5, 2023

benbp commented Oct 5, 2023

jhendrixMSFT commented Oct 5, 2023

benbp commented Oct 5, 2023

jhendrixMSFT commented Oct 5, 2023

Azcore v1.8.0 #21694

Azcore v1.8.0 #21694

Conversation

jhendrixMSFT commented Oct 5, 2023

RickWinter left a comment

Choose a reason for hiding this comment

jhendrixMSFT commented Oct 5, 2023

jhendrixMSFT commented Oct 5, 2023

azure-pipelines bot commented Oct 5, 2023

jhendrixMSFT commented Oct 5, 2023

azure-pipelines bot commented Oct 5, 2023

jhendrixMSFT commented Oct 5, 2023

benbp commented Oct 5, 2023

jhendrixMSFT commented Oct 5, 2023

benbp commented Oct 5, 2023

jhendrixMSFT commented Oct 5, 2023

benbp commented Oct 5, 2023

jhendrixMSFT commented Oct 5, 2023