Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore little warning in travis build #287

Merged
merged 1 commit into from
Mar 4, 2016
Merged

Conversation

ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Mar 4, 2016

./arm/resources$ contains no files, it makes error message confusing.

@ahmetb
Copy link
Contributor Author

ahmetb commented Mar 4, 2016

fixes the issue it's supposed to fix.

$ go vet ./storage/...
storage/blob_test.go:141: no formatting directive in Fatalf call
exit status 1
The command "go vet ./storage/..." exited with 1.

remains as a mystery, I can't locally repro this error on my computer.

ahmetb added a commit that referenced this pull request Mar 4, 2016
Ignore little warning in travis build
@ahmetb ahmetb merged commit de54ca4 into Azure:master Mar 4, 2016
@ahmetb ahmetb deleted the lint-fix branch March 4, 2016 23:23
@colemickens
Copy link
Contributor

 eval "$(gimme tip)"
go version devel +80e5b52 Fri Mar 4 23:15:43 2016 +0000 linux/amd64

Wait, are we using tip of golang to run this? If so, then this is the reason we've just started seeing that failure in Travis: golang/go@867910e (relevant: golang/go#12294)

@ahmetb
Copy link
Contributor Author

ahmetb commented Mar 4, 2016

@colemickens we've been always using tip. Event though we don't always use tip, that'll fix the issue for go vet (because it's part of go.tool) but go lint etc will still be pulled from master.

Thanks for pointing to the bug, should we pin to go1.5?

@ahmetb
Copy link
Contributor Author

ahmetb commented Mar 4, 2016

@colemickens wow wait this tip actually gives you the development version of go. I'm pinning this to 1.6 momentarily.

@colemickens
Copy link
Contributor

It doesn't really matter to me. I generally like being on the bleeding edge and doubt that being on tip will cause us to miss anything in regards to the Travis runs.

If anything we should just point out that the change to tip seems to regress their format-string-check in some cases -- seeing as that storage hit is a false positive, the format string definitely has format placeholders in it.

(I had forgotten that golint was a separate tool; I similarly don't have strong feelings about which version is used).

@ahmetb
Copy link
Contributor Author

ahmetb commented Mar 4, 2016

I was assuming tip actually means tip of stable feed.

@colemickens
Copy link
Contributor

from above:

eval "$(gimme tip)"
go version devel +80e5b52 Fri Mar 4 23:15:43 2016 +0000 linux/amd64

I don't think that's stable.

@ahmetb
Copy link
Contributor Author

ahmetb commented Mar 4, 2016

travis-ci/gimme#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants