go1.7: use TLS renegotiation, rm stdlib forks #375
Conversation
|
LGTM, are you going to update the travis file in the same PR? |
|
@paulmey probably should update that separately when it's out (planned Aug 15). then rebase/merge this. |
|
@ahmetalpbalkan makes sense, I hope travis has the new go version available as soon as its released... |
Go 1.7 introduces TLS renegotiation: golang/go@af125a5 Removing our net/http and crypto/tls forks and just using Renegotation field in the crypto/tls.Config field of the net/http.Client of the ./management/** packages. (Fixes Azure#90) Should be merged once go1.7 stable is out and preferably like 1 month later. If the customers of the ./management/ package are not vendoring the SDK and using go versions prior to 1.7, they will get a compilation error. Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
ahmetb
force-pushed
the
tls-renegotiation
branch
from
8cb192f to
8a163b6
Compare
|
@paulmey tests pass now. |
|
awesome sauce. ship it! |
|
FYI, I understand that it is the right way going forward, but this change is breaking my WinRM library (see masterzen/winrm#60), and prevents users to use Go < 1.7. |
|
You may not be able to (or want to) vendor but you can still lock to a version, allowing you and your users to get a correct set of dependencies. We do this in |
The time for removing the weird
./core/packages has come at last. Go 1.7 introduces TLS renegotiation: golang/go@af125a5The actual change is at
management/http.go(hidden on GitHub UI due to removing so many files, you have to click on it manually, it's all the way at the end.)Removing our net/http and crypto/tls forks and just using Renegotation field
in the crypto/tls.Config field of the net/http.Client of the ./management/**
packages. (Fixes #90)
cc: @paulmey