Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate azure-spring-cloud-servicebus-queue-stream-binder with Spring Boot Health Check (under binders) #14571

Closed
hirowla opened this issue Aug 28, 2020 · 8 comments · Fixed by #23050
Assignees
Labels
azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@hirowla
Copy link

hirowla commented Aug 28, 2020

Is your feature request related to a problem? Please describe.
When using the azure-spring-cloud-servicebus-queue-stream-binder library, the "health" of the binder component is always "UNKNOWN". This should not be the case when a connection to ServiceBus is in fact available. This is the current output.

{
	"status": "UP",
	"components": {
		"binders": {
			"status": "UNKNOWN",
			"components": {
				"servicebus-queue": {
					"status": "UNKNOWN"
				}
			}
		},
	}
}

Describe the solution you'd like
I'd like a health check on the connection to ServiceBus to give an UP/DOWN/STATUS depending on the status of the binder. This should be in a similar way to how it works for the RabbitMQ binder.

The output from the /actuator/health URL would be similar to the following (other pieces removed):

{
	"status": "UP",
	"components": {
		"binders": {
			"status": "UP",
			"components": {
				"servicebus-queue": {
					"status": "UP"
				}
			}
		},
	}
}

Describe alternatives you've considered
There's always a possibility of writing a manual health check, but this would be common for all users of this component so I suggest that it should be provided (like RabbitMQ provides)

Additional context
Add any other context or screenshots about the feature request here.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • [X ] Description Added
  • [X ] Expected solution specified
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 28, 2020
@joshfree joshfree added azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. feature-request This issue requires a new behavior in the product in order be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 28, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 28, 2020
@joshfree
Copy link
Member

Hi @hirowla, someone from the azure-spring team will follow up with you shortly on this issue.

/cc @jialindai @hemanttanwar

@yiliuTo yiliuTo added this to the Backlog milestone Aug 31, 2020
@yiliuTo
Copy link
Member

yiliuTo commented Aug 31, 2020

Hi @hirowla , thanks for your reporting. We will investigate this feature.

@seanli1988
Copy link
Contributor

We've backlogged this ask and will provide an update by November this year.

@jialindai jialindai added the Client This issue points to a problem in the data-plane of the library. label Feb 20, 2021
@ArtyomGabeev
Copy link

hi,

we are interested in this feature as well!

@born-to-be-mad
Copy link

Looking forward for the solution.

@chenrujun chenrujun modified the milestones: Backlog, [2021] August May 26, 2021
@chenrujun chenrujun assigned yiliuTo and unassigned chenrujun Jun 1, 2021
@Manuel-Moya
Copy link

Manuel-Moya commented Jul 14, 2021

Any progress on this? It is a very important feature. For Topic as well.

@yiliuTo
Copy link
Member

yiliuTo commented Jul 15, 2021

@Manuel-Moya The health check for both Azured Spring Cloud Service Bus queue & topic binders are under development now, please stay tuned.

@yiliuTo yiliuTo linked a pull request Aug 4, 2021 that will close this issue
@ZhuXiaoBing-cn
Copy link
Contributor

ZhuXiaoBing-cn commented Aug 10, 2021

The PR of the service bus health indicator has been merged into the main branch, please wait for the next release.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants