Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Provide a health indicator for Service Bus Spring starter #21976

Closed
Tracked by #23402 ...
saragluna opened this issue Jun 1, 2021 · 14 comments · Fixed by #23050
Closed
Tracked by #23402 ...

[FEATURE REQ] Provide a health indicator for Service Bus Spring starter #21976

saragluna opened this issue Jun 1, 2021 · 14 comments · Fixed by #23050
Labels
azure-spring All azure-spring related issues azure-spring-boot Label for spring issues related with Spring Boot Auto-configuration azure-spring-servicebus Spring service bus related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@saragluna
Copy link
Member

saragluna commented Jun 1, 2021

Context

In Spring Cloud Azure 4.0, we added a starter for Azure Service Bus. Each client should have one health indicator for it, and it's the same for the Service Bus clients.

Goal

With this health indicator, users shall be able to check the health status of Service Bus clients.

@saragluna
Copy link
Member Author

Reopen it for the Service Bus health indicator hasn't been added for auto-configuration.

@saragluna saragluna reopened this Sep 28, 2021
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Nov 5, 2021
@chenrujun chenrujun modified the milestones: [2021] August, Backlog Nov 5, 2021
@saragluna saragluna added the Client This issue points to a problem in the data-plane of the library. label Nov 7, 2021
@saragluna saragluna modified the milestones: Backlog, [2021] December Nov 7, 2021
@chenrujun chenrujun removed this from the [2021] December milestone Nov 8, 2021
@saragluna
Copy link
Member Author

@stliu stliu added the feature-request This issue requires a new behavior in the product in order be resolved. label Apr 3, 2022
@saragluna saragluna changed the title Implement health indicators for messaging components [Feature Request] Implement health indicators for messaging components Apr 28, 2022
@saragluna saragluna changed the title [Feature Request] Implement health indicators for messaging components [Feature Request] Provide health indicators for Service Bus Spring starter Apr 28, 2022
@saragluna saragluna changed the title [Feature Request] Provide health indicators for Service Bus Spring starter [Feature Request] Provide a health indicator for Service Bus Spring starter Apr 28, 2022
@jialigit jialigit added the azure-spring-servicebus Spring service bus related issues. label May 12, 2022
@jialigit jialigit removed their assignment Jul 8, 2022
@stliu stliu moved this from Todo to Blocked in Spring Cloud Azure Aug 16, 2022
@stliu
Copy link
Member

stliu commented Nov 22, 2022

#30507

@saragluna saragluna changed the title [Feature Request] Provide a health indicator for Service Bus Spring starter [FEATURE REQ] Provide a health indicator for Service Bus Spring starter Dec 12, 2022
@AndreasPetersen
Copy link

I'm sorry, I'm a bit confused with all these issues being linked throughout.

Is it possible to get health indicators through the service bus clients, or is this still in the backlog?

@saragluna
Copy link
Member Author

saragluna commented Jan 3, 2023

Sorry @AndreasPetersen, it's still in the backlog. We will look into the tracing implementation in #30507 to see whether it can provide the health info, but this feature request is a lower priority now.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this issue Jan 6, 2023
Add new tier and sku - Standard_Basic for Application Gateway (Azure#21976)

* Add new tier and sku for standard_basic

* spaces
@yiliuTo yiliuTo added azure-spring-boot Label for spring issues related with Spring Boot Auto-configuration azure-spring-zinc and removed azure-spring-zinc labels Jan 9, 2023
@stliu stliu moved this from Blocked to Todo in Spring Cloud Azure Jan 20, 2023
@AndreasPetersen
Copy link

AndreasPetersen commented Apr 24, 2023

I see that #30507 is closed, being marked as a duplicate of #26269, which is also closed as completed. Where does that leave this issue?

@saragluna
Copy link
Member Author

The tracer will collect information whenever sending or receiving messages, but what if an application with a sender or receiver but has no messages flowing, should we consider the application is healthy? So for a health indicator we should not depend on the messages flowing on the connection, metrics like active connection might be more suitable in this case.

@AndreasPetersen
Copy link

Would it be possible to send a ping message to check the health of the connection? The lack of a health indicator is a huge issue for us given #34588 .

@Netyyyy
Copy link
Member

Netyyyy commented Aug 3, 2023

Hi @AndreasPetersen , the service bus sdk client doesn't expose any interfaces for us to check the status of it, so it's still blocked.

@AndreasPetersen
Copy link

Hi @AndreasPetersen , the service bus sdk client doesn't expose any interfaces for us to check the status of it, so it's still blocked.

Thank you for the reply @Netyyyy . Is there an issue on exposing any such interfaces?

@Netyyyy
Copy link
Member

Netyyyy commented Aug 3, 2023

Hi @AndreasPetersen , the service bus sdk client doesn't expose any interfaces for us to check the status of it, so it's still blocked.

Thank you for the reply @Netyyyy . Is there an issue on exposing any such interfaces?

Sorry, I have no idea about that. Maybe @anuchandy could help you.

Copy link

Hi @saragluna, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Spring Cloud Azure Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-boot Label for spring issues related with Spring Boot Auto-configuration azure-spring-servicebus Spring service bus related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants