Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the code quality of azure-spring-boot-samples #26169

Closed
1 task done
Tracked by #26166
, #27868
...
backwind1233 opened this issue Dec 24, 2021 · 2 comments
Closed
1 task done
Tracked by #26166
, #27868
...

Improve the code quality of azure-spring-boot-samples #26169

backwind1233 opened this issue Dec 24, 2021 · 2 comments
Labels
azure-spring All azure-spring related issues azure-spring-samples Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
Backlog

Comments

@backwind1233
Copy link
Contributor

backwind1233 commented Dec 24, 2021 •
edited
Loading

Content

Address quality issues mentioned in the doc: Thing to do to before GA

Problem

[Fixed]Here is some known issues:

  • multiple-namespaces
    • Migrate bean definition to a configuration class
      • Rename QueueReceiveController, should not be ***controller, migrate bean inside the controller to configuration class.
      • Migrate bean definition inside ServiceBusIntegrationApplication to a configuration class.
      • Migrate bean definition inside QueueSendController to a configuration class.
      • Migrate bean definition inside QueueReceiveController to a configuration class.
      • Rename QueueReceiveController.
    • Let QueueSendController implement CommandlineRunner to send message in auto way.

Goal
Find all problems in sample repository and solve these problems.

Solution

  • Go through all the samples to make sure our code quality is production-ready.

Spring Cloud Azure Samples improvement Track

Sample Name code quality
aad-resource-server  
aad-resource-server-by-filter  
aad-resource-server-by-filter-stateless  
aad-resource-server-obo  
aad-web-application  
aad-web-application-and-resource-server  
aad-b2c-web-application  
aad-b2c-resource-server  
spring-security  
azure-appconfiguration-conversion-sample-complete  
azure-appconfiguration-conversion-sample-initial  
azure-appconfiguration-sample  
feature-management-sample  
feature-management-web-sample  
azure-cloud-foundry-service-sample  
spring-cloud-azure-data-cosmos-sample  
spring-cloud-azure-cosmos-sample  
cosmos-multi-database-multi-account  
cosmos-multi-database-single-account  
eventhubs-integration  
spring-cloud-azure-sample-eventhubs-kafka  
eventhubs-binder  
eventhubs-multibinders  
run-with-command-line-server-side  
run-with-command-line-client-side  
keyvault-certificates-client-side  
keyvault-certificates-server-side  
single-property-source  
multiple-property-source  
servicebus-jms-queue  
servicebus-jms-topic  
servicebus-queue-binder  
servicebus-multibinders  
servicebus-topic-binder  
multiple-namespaces  
single-namespace  
storage-blob-sample  
storage-file-sample  
storage-queue-operation  
storage-queue-integration  
spring-petclinic-microservices  
@backwind1233 backwind1233 mentioned this issue Dec 24, 2021
Closed
29 tasks
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 24, 2021
@backwind1233 backwind1233 self-assigned this Dec 24, 2021
@backwind1233 backwind1233 added the azure-spring All azure-spring related issues label Dec 24, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 24, 2021
@backwind1233 backwind1233 added this to the [2022] January milestone Dec 24, 2021
@backwind1233 backwind1233 mentioned this issue Jan 4, 2022
Merged
@saragluna saragluna added Client This issue points to a problem in the data-plane of the library. azure-spring-samples labels Jan 17, 2022
@saragluna saragluna moved this to Todo in Spring Cloud Azure Jan 21, 2022
@backwind1233 backwind1233 changed the title improve the code quality of azure-spring-boot-samples Improve the code quality of azure-spring-boot-samples Jan 21, 2022
@backwind1233 backwind1233 mentioned this issue Mar 25, 2022
Closed
10 tasks
@stliu stliu added the feature-request This issue requires a new behavior in the product in order be resolved. label Apr 3, 2022
@saragluna saragluna assigned chenrujun and unassigned chenrujun Apr 28, 2022
@backwind1233 backwind1233 removed their assignment Dec 9, 2022
@stliu stliu assigned backwind1233 and unassigned chenrujun Dec 10, 2022
@saragluna
Copy link
Member

Azure-Samples/azure-spring-boot-samples#608

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this issue Nov 2, 2023
@dishantmunjal @chandrasekarendran
@soumyapattnaik @nickpacificomsft @asmitt
CodeGen from PR 25967 in Azure/azure-rest-api-specs
254267b 
[Hub Generated] Review request for Microsoft.DataProtection to add version preview/2023-08-01-preview (Azure#25967)

* Adds base for updating Microsoft.DataProtection from version preview/2023-06-01-preview to version 2023-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* Re-Validate API Swagger Changes

* JobCancel & Job InProgress changes

* vault tier changes aks (Azure#25972)

* Add is isPartialRP boolean to AzureBackupDiscreteRecoveryPoint and examples (Azure#25974)

* Add is ispartialrp to AzureBackupDiscreteRecoveryPoint and examples

* Fix prettier issues in examples

* Including ValidateForModifyBackupRequest Defn.

* resolved comments (Azure#26064)

* Revert IsPartialRP changes (Azure#26070)

* Using Restricted Pattern for Vault Name (Azure#26169)

* Handling Validation Errors (Azure#26186)

* removing 200 status code

* LintDiff fix - using common types error response (Azure#26187)

* whitespace handling

* Editing where clause

* Removing Where Condition

---------

Co-authored-by: Dishant Munjal <dishantmunjal@users.noreply.github.com>
Co-authored-by: chandrasekarendran <59728024+chandrasekarendran@users.noreply.github.com>
Co-authored-by: soumyapattnaik <33341338+soumyapattnaik@users.noreply.github.com>
Co-authored-by: nickpacificomsft <144935783+nickpacificomsft@users.noreply.github.com>
Co-authored-by: asmitt <62243673+asmitt@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

Hi @backwind1233, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Spring Cloud Azure Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
azure-spring All azure-spring related issues azure-spring-samples Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Spring Cloud Azure
Archived in project
Milestone
Backlog
Development

No branches or pull requests
4 participants
@stliu @backwind1233 @chenrujun @saragluna