Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnableSupportLogging (Allow extraction of all MSAL logs) #34072

Closed
scottaddie opened this issue Mar 16, 2023 · 3 comments · Fixed by #36115
Closed

EnableSupportLogging (Allow extraction of all MSAL logs) #34072

scottaddie opened this issue Mar 16, 2023 · 3 comments · Fixed by #36115
Assignees
@billwert
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
2023-07

Comments

@scottaddie
Copy link
Member

Context:
When customers encounter bugs in MSAL, the MSAL team needs detailed logs to diagnose the issue. The Azure Identity library doesn't have a provision to extract all these logs. In particular, we need verbose logs with PII information. For context, MSAL exposes 2 knobs for logging:

  1. The log verbosity, which is very closely related to Azure SDK’s verbosity, i.e. Verbose, Info, Warning, Error.
  2. A PII flag, false by default. Note: For a cheat sheet of what gets logged, see https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/wiki/PII.

The request is to allow app developers using the Azure Identity library to collect Verbose + PII logs from MSAL, on request, which are sometimes needed for supportability. The Azure Identity library exposes some knobs already, but there's no alignment over PII.
@scottaddie scottaddie added Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. labels Mar 16, 2023
@scottaddie scottaddie added this to the Backlog milestone Mar 16, 2023
@joshfree joshfree modified the milestones: Backlog, 2023-05 Apr 3, 2023
@joshfree joshfree modified the milestones: 2023-05, 2023-06 Apr 30, 2023
@joshfree joshfree moved this from Blocked to Planned in Azure Identity SDK Improvements May 31, 2023
@joshfree
Copy link
Member

Related https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1755813/?triage=true

@joshfree
Copy link
Member

joshfree commented Jun 8, 2023

EnableSupportLogging is the name we're landing on.

@pvaneck
Copy link
Member

pvaneck commented Jun 9, 2023

Example enabling Pii logging: https://learn.microsoft.com/en-us/azure/active-directory/develop/msal-logging-java#personal-and-organization-information

@joshfree joshfree modified the milestones: 2023-06, 2023-07 Jun 19, 2023
@billwert billwert modified the milestones: 2023-07, 2023-08 Jun 19, 2023
@joshfree joshfree moved this from Planned to In Progress in Azure Identity SDK Improvements Jul 10, 2023
@joshfree joshfree changed the title Allow extraction of all MSAL logs from Azure Identity library EnableSupportLogging (Allow extraction of all MSAL logs) Jul 17, 2023
billwert added a commit to billwert/azure-sdk-for-java that referenced this issue Jul 26, 2023
@billwert
Add EnableSupportLogging feature
1efc0dc 
This enables users to turn on support logging for MSAL4j. Fixes Azure#34072
@billwert billwert mentioned this issue Jul 26, 2023
Merged
billwert added a commit that referenced this issue Jul 28, 2023
@billwert
Add EnableSupportLogging feature (#36115)
42e2d5d 
* Add EnableSupportLogging feature

This enables users to turn on support logging for MSAL4j. Fixes #34072

* pr feedback

* fix test mocks

* remove en-us from learn.microsoft.com URLs.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure Identity SDK Improvements Jul 28, 2023
This was referenced Aug 3, 2023
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@billwert billwert

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Azure Identity SDK Improvements
Archived in project
Milestone
2023-07
Development

Successfully merging a pull request may close this issue.

Add EnableSupportLogging feature billwert/azure-sdk-for-java
4 participants
@joshfree @pvaneck @billwert @scottaddie