Migrate test recording, for mgmt-plane

[weidongxu-microsoft]

link #33342

We'd need to check if these work

• normal recording
• recording with random name/guid (i.e. they are saved to json, and loaded at playback)
• redact of secret (need to know whether we can still run script to redact it, before e.g. upload to somewhere we no longer control; or we can use TestBase to redact); if now request body is also recorded, we may need to add more redact rules

We may try

1. resources (random name)
2. storage (secret)
3. appservice or ACI/ACR (different kind of secret)

---

We also need to see if we can still batch modify api-version in recorded data, after phase2
We need this e.g. after upgrade resources RP or network RP
https://github.com/Azure/azure-sdk-assets/blob/main/README.md
e.g. upgrade Network would modify more tests #34243 (comment)

---

Another question on the "azure-sdk-assets" repo is: how it handles different recording from different branch (e.g. one branch may release a preview api-version, but main on stable)

[ghost]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @weidongxu-microsoft, @XiaofeiCao

[weidongxu-microsoft]

on redact

We now have TestProxySanitizers to handle the redaction.

A lot of default redaction are already placed here https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/core/azure-core-test/src/main/java/com/azure/core/test/utils/TestProxyUtils.java#L144

 On top of that, we can do custom redactions too.

Examples - https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/core/azure-core-test/src/test/java/com/azure/core/test/TestProxyTests.java#L64-L67

[weidongxu-microsoft]

Most recording would be under "sdk/resourcemanager".

Very few other places, as mgmt recommend live tests for simpler RP
One of them:
https://github.com/Azure/azure-sdk-for-java/tree/main/sdk/confidentialledger/azure-resourcemanager-confidentialledger/src/test/resources/session-records
<-- this can be used as a pilot migration, however it is not representative for complex cases

[weidongxu-microsoft]

You can contact Sameeksha, if more question.

[haolingdong-msft]

Hey @samvaity, may I know do we have timeline of migrating to the new test recording framework?

[haolingdong-msft]

Reference links:
issue on test proxy: #33342
example pr: #33902

[haolingdong-msft]

Met issue on connecting to local test proxy server. Question here: #33342 (comment)

[haolingdong-msft]

Started working on azure-resourcemanager-resources

[haolingdong-msft]

Reference links

Testproxy migration: https://github.com/Azure/azure-sdk-for-java/wiki/Test-Proxy-Migration
sample pr: #35186
resources pr: https://github.com/Azure/azure-sdk-for-java/pull/35476/files

[haolingdong-msft]

Todos:

1. try remove TextReplacementPolicy
2. retry-after = 0, make sure long lro can run successfully, e.g. sql server
3. storage, response body secret sanitize
   solution here: https://github.com/samvaity/azure-sdk-for-java/tree/add-docs-test-proxy/sdk/core/azure-core-test#sanitize-secrets
   
4. credcheck before push to asset repo? (there is already DefaultSanitizer, not sure if it includes all we want)
5. migration for other RPs.