Rename apiKey() to credential() in FormRecognizer and TextAnalytics ClientBuilder

[samvaity]

Fixes #10737

[sima-zhu]

Why are the tests removed?

[samvaity]

Now that we have two overloads for the credential in the builder, it cannot resolve at compile time to pass in null object.

[mssfang]

assigning the null value to a type value, such as AzureKeyCredential credential = null, and replace null value with credential will resolve it. `=

[sima-zhu]

You can also do cast in API.
.credential((AzureKeyCredential) null)

[sima-zhu]

Search is validating apiKeyCredential.getKey empty or null case.

[sima-zhu]

Moreover, if the credential is required, we can move the validation up to buildClient()

[samvaity]

It does have that here - https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/formrecognizer/azure-ai-formrecognizer/src/main/java/com/azure/ai/formrecognizer/FormRecognizerClientBuilder.java#L181

[sima-zhu]

public SearchServiceClientBuilder credential(AzureKeyCredential keyCredential) {
        if (keyCredential == null) {
            throw logger.logExceptionAsError(new NullPointerException("'keyCredential' cannot be null."));
        }
        if (CoreUtils.isNullOrEmpty(keyCredential.getKey())) {
            throw logger.logExceptionAsError(
                new IllegalArgumentException("'keyCredential' cannot have a null or empty API key."));
        }
        this.keyCredential = keyCredential;
        return this;
    }

Here is how search do validation for your reference.

[samvaity]

@sima-zhu Could this

if (keyCredential == null) {
throw logger.logExceptionAsError(new NullPointerException("'keyCredential' cannot be null."));
}

be replaced with

   this.credential = Objects.requireNonNull(keyCredential, "'keyCredential' cannot be null.");

And also for the rest of the code, I see that we are already doing the empty checks here and here. It would be redundant?

[sima-zhu]

Looks good to me

[srnagar]

Method name should be renamed too.

[srnagar]

Update the name of the class to RotateAzureKeyCredential

[srnagar]

Use azure_key_credential instead of api_key everywhere to be consistent with terminology.

[samvaity]

updated to say key as that is what it is called in Portal.

[samvaity]

/azp run java - textanalytics - ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).