Added content response on write enabled feature to Gateway and Direct TCP by kushagraThapar · Pull Request #10741 · Azure/azure-sdk-for-java

kushagraThapar · 2020-05-06T00:22:55Z

This PR:

Adds contentResponseOnWriteEnabled argument to CosmosClientBuilder and all internal client builders.
By default the value for the argument is set to false -> Item write operations will not return content response.
This feature only works in Gateway and Direct TCP mode. (Direct HTTP is implemented on the backend, but needs to be released)
Exposes new APIs - getETag() on CosmosItemResponse and CosmosAsyncItemResponse
Added configuration options for Write Throughput and Write Latency Benchmarks.
Updated client builders in TestSuiteBase to support contentResponseOnWriteEnabled testing.
Updated and closed some open github issues that have already been fixed.

…tem write operations

...s-examples/src/main/java/com/azure/cosmos/examples/ChangeFeed/SampleChangeFeedProcessor.java

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncClient.java

...mos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentServiceRequest.java

kirankumarkolli

Waiting on name closure

...os/src/main/java/com/azure/cosmos/implementation/directconnectivity/HttpTransportClient.java

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java

sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/ReturnMinimalResponseTest.java

Updated cosmos container and database tests to emulator groups. Removed prefer header generic logic

kushagraThapar · 2020-05-06T06:35:55Z

/azp run java - cosmos - tests

azure-pipelines · 2020-05-06T06:36:05Z

Azure Pipelines successfully started running 1 pipeline(s).

kirankumarkolli · 2020-05-06T07:20:22Z

Would be nice to behcnmark with this change in.

moderakh

some minor comments. other than that LGTM

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClientBuilder.java

David-Noble-at-work

LGTM

...s/src/main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdConstants.java

.../main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdRequestHeaders.java

sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/VeryLargeDocumentQueryTest.java

...mos/azure-cosmos/src/test/java/com/azure/cosmos/rx/UserDefinedFunctionUpsertReplaceTest.java

sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/ParallelDocumentQueryTest.java

kushagraThapar · 2020-05-06T16:47:58Z

/azp run java - cosmos - tests

azure-pipelines · 2020-05-06T16:48:12Z

Azure Pipelines successfully started running 1 pipeline(s).

… clients with content response on write flag

kushagraThapar · 2020-05-06T18:45:24Z

/azp run java - cosmos - tests

azure-pipelines · 2020-05-06T18:45:34Z

Azure Pipelines successfully started running 1 pipeline(s).

…sts to reflect correct value

kushagraThapar · 2020-05-06T20:38:59Z

/azp run java - cosmos - tests

azure-pipelines · 2020-05-06T20:39:10Z

Azure Pipelines successfully started running 1 pipeline(s).

… write latency

kushagraThapar · 2020-05-06T22:11:52Z

/azp run java - cosmos - tests

azure-pipelines · 2020-05-06T22:12:02Z

Azure Pipelines successfully started running 1 pipeline(s).

kushagraThapar · 2020-05-07T00:44:36Z

/azp run java - cosmos - tests

azure-pipelines · 2020-05-07T00:44:47Z

Azure Pipelines successfully started running 1 pipeline(s).

kushagraThapar · 2020-05-07T15:52:07Z

Single region session long CI failed after running all the tests successfully with spot bugs jar downloads.

2020-05-07T15:44:56.2558748Z [ERROR] Failed to execute goal com.github.spotbugs:spotbugs-maven-plugin:3.1.12.2:spotbugs (spotbugs) on project azure-cosmos: Execution spotbugs of goal com.github.spotbugs:spotbugs-maven-plugin:3.1.12.2:spotbugs failed: Plugin com.github.spotbugs:spotbugs-maven-plugin:3.1.12.2 or one of its dependencies could not be resolved: The following artifacts could not be resolved: org.apache.bcel:bcel:jar:6.3.1, net.jcip:jcip-annotations:jar:1.0, org.dom4j:dom4j:jar:2.1.1, jaxen:jaxen:jar:1.1.6: Could not transfer artifact org.apache.bcel:bcel:jar:6.3.1 from/to ossrh (https://oss.sonatype.org/content/repositories/snapshots/): Transfer failed for https://oss.sonatype.org/content/repositories/snapshots/org/apache/bcel/bcel/6.3.1/bcel-6.3.1.jar: Connection reset -> [Help 1]

kushagraThapar · 2020-05-07T17:14:19Z

Single Region Strong Https e2e failed because of lots of SSLEngine closed already reactor-netty issue.
I think it might have caused the VM to crash. I have added more information on this issue:
#7349

Added return minimal response feature to Gateway and Direct TCP for i…

4239e8b

…tem write operations

kushagraThapar requested review from David-Noble-at-work, kirankumarkolli, mbhaskar and moderakh as code owners May 6, 2020 00:22

kirankumarkolli reviewed May 6, 2020

View reviewed changes

...s-examples/src/main/java/com/azure/cosmos/examples/ChangeFeed/SampleChangeFeedProcessor.java Outdated Show resolved Hide resolved

kirankumarkolli reviewed May 6, 2020

View reviewed changes

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncClient.java Outdated Show resolved Hide resolved

kirankumarkolli reviewed May 6, 2020

View reviewed changes

...mos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentServiceRequest.java Show resolved Hide resolved

kirankumarkolli requested changes May 6, 2020

View reviewed changes

moderakh reviewed May 6, 2020

View reviewed changes

Updated name to noContentResponseOnWrite.

85d8c46

Updated cosmos container and database tests to emulator groups. Removed prefer header generic logic

kushagraThapar changed the title ~~Added return minimal response feature to Gateway and Direct TCP~~ Added no content response on write feature to Gateway and Direct TCP May 6, 2020

kirankumarkolli approved these changes May 6, 2020

View reviewed changes

moderakh approved these changes May 6, 2020

View reviewed changes

FabianMeiswinkel approved these changes May 6, 2020

View reviewed changes

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClientBuilder.java Show resolved Hide resolved

moderakh reviewed May 6, 2020

View reviewed changes

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClientBuilder.java Outdated Show resolved Hide resolved

moderakh reviewed May 6, 2020

View reviewed changes

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClientBuilder.java Outdated Show resolved Hide resolved

David-Noble-at-work approved these changes May 6, 2020

View reviewed changes

Finalized name and updated documentation regarding RU usage

c9d3377

kushagraThapar changed the title ~~Added no content response on write feature to Gateway and Direct TCP~~ Added content response on write enabled feature to Gateway and Direct TCP May 6, 2020

Fixed benchmark configurations, internal TestSuiteBase async document…

86b4710

… clients with content response on write flag

Fixed more tests by enabling content on response. Updated names of te…

228f38b

…sts to reflect correct value

Fixed negation check of content response flag on write throughput and…

f03e4a8

… write latency

Fixed more tests client builders with content response on write disabled

4a75226

kushagraThapar merged commit 3742ebf into Azure:master May 7, 2020

Conversation

kushagraThapar commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kirankumarkolli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kushagraThapar commented May 6, 2020

Uh oh!

azure-pipelines bot commented May 6, 2020

Uh oh!

kirankumarkolli commented May 6, 2020

Uh oh!

moderakh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

David-Noble-at-work left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kushagraThapar commented May 6, 2020

Uh oh!

azure-pipelines bot commented May 6, 2020

Uh oh!

kushagraThapar commented May 6, 2020

Uh oh!

azure-pipelines bot commented May 6, 2020

Uh oh!

kushagraThapar commented May 6, 2020

Uh oh!

azure-pipelines bot commented May 6, 2020

Uh oh!

kushagraThapar commented May 6, 2020

Uh oh!

azure-pipelines bot commented May 6, 2020

Uh oh!

kushagraThapar commented May 7, 2020

Uh oh!

azure-pipelines bot commented May 7, 2020

Uh oh!

kushagraThapar commented May 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kushagraThapar commented May 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

kushagraThapar commented May 6, 2020 •

edited

Loading

kushagraThapar commented May 7, 2020 •

edited

Loading