Conversation
JimSuplizio
requested review from
conniey,
hemanttanwar,
nemakam and
yvgopal
as code owners
conniey
approved these changes
May 6, 2020
weshaggard
approved these changes
May 6, 2020
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
I'm good with this change however we should consider at some point flipping these paths to be only include filters.
Contributor
Author
|
The linux issues with the client library are being looked at as is the issue with the analyze on the data. My change just prevents the data pipeline from running for client changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci.data.yml wasn't correctly excluding sdk/servicebus/azure-messaging-servicebus which was causing it to get kicked off when changes were made to the client library