Update scan_for_unreleased_dependencies.ps1#10961
Conversation
JimSuplizio
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
| continue | ||
| } else { | ||
| # If this is an external dependency then continue | ||
| if ($versionUpdateTag -match "external_dependency}") { |
There was a problem hiding this comment.
I think it is actually a good idea to do a check for both internal and external dependencies. I'd suggest we use the SemVer.ps1 script we have under common and check to see if our version and if it is not prerelease then we should error for any dependency that is marked as a prerelease.
There was a problem hiding this comment.
@weshaggard, sure. I can look and see if this is feasible for external_dependencies on Monday. There are, unfortunately, beta external dependencies. Also, I'd have to verify that the SemVer.ps1 does correctly parse all of the external dependency versions first as Maven is a bit more liberal with what it allows for versions.
There was a problem hiding this comment.
I hope we don't depend on external prereleases in our GA packages that will definitely be a recipe for potential disaster.
There was a problem hiding this comment.
We do but only in a scope. I'm less concerned about external dependencies since the maven-enforcer-plugin was added and every dependency is now being scrutinized (track 2 only though).
4 participants
There was issue this week where a library was allowed to ship GA with beta dependencies. The fix here is to ensure that any dependency that not an external_dependency (aka, something we build/ship) has its version checked. If the version is beta and the library being shipped is GA, then we fail. The output would look like this:
inputGroupId=com.azure
inputArtifactId=azure-core-amqp
serviceDirectory=C:\src\azure-sdk-for-java\sdk\core
Found pom file with matching groupId(com.azure)/artifactId(azure-core-amqp), pomFile=C:\src\azure-sdk-for-java\sdk\core\azure-core-amqp\pom.xml
Library is not releasing as Beta, version=1.1.1
Error: Cannot release non-beta libraries with beta dependencies. dependency={x-version-update;com.azure:azure-core;current}, version=1.6.0-beta.1