Update Storage ci.yml Additional Modules#10982
Merged
alzimmermsft merged 3 commits intoAzure:masterfrom May 9, 2020
Merged
Conversation
…nt Store to build properly
JimSuplizio
approved these changes
May 8, 2020
Contributor
JimSuplizio
left a comment
JimSuplizio
left a comment
There was a problem hiding this comment.
I'm going to pre-approve. This was the only module that the amd switch complained about.
alzimmermsft
changed the title
Contributor
|
Good find! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the nature of the
-amdswitch that is used during theFrom Sourcebuildsazure-messaging-eventhubs-checkpoint-storefails to compile due to it, rightfully, being unable to find an unreleased version ofazure-messaging-eventhubs. The change in this PR addsazure-messaging-eventhubsas an additional module that will be used during compile and test run time, this module won't show up as an option in the release pipeline. Adding this will allow theFrom Sourcebuilds to properly compile, allowing us to verify the future state when in development modules are released and dependency versions are updated. Additionally this should unblock PR #10979.This issue was being masked, and would have been noticed earlier, but the
azure-messaging-eventhubsand-checkpoint-storein development versions were incorrectly listed as5.1.0-beta.1and1.1.0-beta.1respectively. These versions were released to Maven last month for a preview build EventHubs had and should have been updated tobeta.2but this was forgotten, additionally this didn't have a update versions PR to master as this was released from a branch. The release process wiki will be updated in the next few days to outline what should happen when a beta or hotfix is released from a branch so this scenario doesn't happen again.@srnagar @mitchdenny @JimSuplizio @rickle-msft