Form training client API consistency issues#11097
Merged
samvaity merged 8 commits intoAzure:masterfrom May 14, 2020
Merged
Conversation
samvaity
requested review from
JonathanGiles,
mssfang and
sima-zhu
as code owners
samvaity
requested review from
annelo-msft,
iscai-msft,
jeremymeng,
kristapratico and
willmtemple
samvaity
force-pushed
the
formtraining-client-updates
branch
4 times, most recently
from
cfa7ce9 to
5bc0642
Compare
samvaity
force-pushed
the
formtraining-client-updates
branch
from
5bc0642 to
ac8a7c4
Compare
mssfang
reviewed
May 12, 2020
...zure-ai-formrecognizer/src/main/java/com/azure/ai/formrecognizer/implementation/Utility.java
Show resolved
Hide resolved
mssfang
reviewed
May 12, 2020
...ai-formrecognizer/src/main/java/com/azure/ai/formrecognizer/training/FormTrainingClient.java
Outdated
Show resolved
Hide resolved
mssfang
reviewed
May 12, 2020
...src/samples/java/com/azure/ai/formrecognizer/FormTrainingAsyncClientJavaDocCodeSnippets.java
Outdated
Show resolved
Hide resolved
iscai-msft
reviewed
May 12, 2020
...zure-ai-formrecognizer/src/main/java/com/azure/ai/formrecognizer/implementation/Utility.java
Show resolved
Hide resolved
...rmrecognizer/src/main/java/com/azure/ai/formrecognizer/training/FormTrainingAsyncClient.java
Outdated
Show resolved
Hide resolved
...ai-formrecognizer/src/main/java/com/azure/ai/formrecognizer/training/FormTrainingClient.java
Show resolved
Hide resolved
...src/samples/java/com/azure/ai/formrecognizer/FormTrainingAsyncClientJavaDocCodeSnippets.java
Outdated
Show resolved
Hide resolved
...src/samples/java/com/azure/ai/formrecognizer/FormTrainingAsyncClientJavaDocCodeSnippets.java
Show resolved
Hide resolved
kristapratico
approved these changes
May 13, 2020
iscai-msft
approved these changes
May 13, 2020
| ## 1.0.0-beta.3 (Unreleased) | ||
|
|
||
| FormTraining Client updates: | ||
| - Adopt to `training` namespace for Form Recognizer Training Clients |
Contributor
There was a problem hiding this comment.
nitpick: adopt the training... (sorry)
mssfang
reviewed
May 13, 2020
| // BEGIN: com.azure.ai.formrecognizer.training.FormTrainingClient.beginTraining#string-boolean-trainModelOptions-Duration | ||
| String trainingFilesUrl = "{training-set-SAS-URL}"; | ||
| TrainModelOptions trainModelOptions = new TrainModelOptions().setIncludeSubFolders(false) | ||
| .setPrefix("Invoice"); |
Contributor
There was a problem hiding this comment.
nit: doesn't need a new line
mssfang
approved these changes
May 13, 2020
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trainingnamespace to align with .NETTrainModelOptionstrainingFilesUrluseTrainingLabels.customModelCountandcustomModelLimit