Skip to content

feat: update pom after generation #11417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChenTanyi merged 2 commits into from
May 25, 2020
Merged

feat: update pom after generation #11417

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab64d5b
feat: update pom after generation
ChenTanyi May 25, 2020
e82765e
fix: write back to pom
ChenTanyi May 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 53 additions & 2 deletions eng/mgmt/gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ var handleInput = function(projects, cb) {
}
}

var codegen = function(project, cb) {
var codegen = async function(project, cb) {
if (!args['preserve']) {
deleteMgmtFolders(project);
}
Expand Down Expand Up @@ -157,7 +157,10 @@ var codegen = function(project, cb) {
}

console.log('Command: ' + cmd);
return execa(cmd, [], { shell: true, stdio: "inherit" });
await execa(cmd, [], { shell: true, stdio: "inherit" });
if (cmd.includes('--multiapi')) {
changePom(project);
}
};

var deleteMgmtFolders = function(project) {
Expand Down Expand Up @@ -202,6 +205,54 @@ var deleteFolderRecursive = function(folder) {
}
};

var changePom = function(project) {
var modules = []

project = project.split('/')[0]
var projectRoot = path.join(sdkRoot, 'sdk', project);
var projectPom = path.join(projectRoot, mgmtPomFilename);

// search modules
fs.readdirSync(projectRoot).forEach(function(folder, index) {
if (fs.lstatSync(path.join(projectRoot, folder)).isDirectory()) {
if (folder.startsWith('mgmt-')) {
modules.push(folder);
}
}
})

pomHeader =
`<!-- Copyright (c) Microsoft Corporation. All rights reserved.
Licensed under the MIT License. -->
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">`;
pomVersion = '<version>1.0.0</version> <!-- Need not change for every release-->'

// add all modules to pom
if(fs.existsSync(projectPom)) {
var xmlContent = fs.readFileSync(projectPom, {encoding: 'utf-8'});
var xml = xmlparser.parse(xmlContent);
xml.project.modules.module = modules;
xmlContent = new xmlparser.j2xParser({format: true, indentBy: " "}).parse(xml);
xmlContent = xmlContent.replace('<project>', pomHeader);
xmlContent = xmlContent.replace('<version>1.0.0</version>', pomVersion);

fs.writeFileSync(projectPom, xmlContent, {encoding: 'utf-8'})
}

// change all module pom.xml
modules.forEach(function(mod, index) {
var modulePom = path.join(projectRoot, mod, 'pom.xml');
if (fs.existsSync(modulePom)) {
var pomContent = fs.readFileSync(modulePom, {encoding: 'utf-8'});
pomContent = pomContent.replace('<version>1.1.0</version>', '<version>1.3.0</version>');
pomContent = pomContent.replace('<relativePath>../../../pom.management.xml</relativePath>', '<relativePath>../../parents/azure-arm-parent/pom.xml</relativePath>');
Copy link
Contributor

@xseeseesee xseeseesee May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For safe replacement, it might be required to append at line 251 with
pomContent = pomContent.replace('<relativePath>../../pom.management.xml</relativePath>', '<relativePath>../../parents/azure-arm-parent/pom.xml</relativePath>');

fs.writeFileSync(modulePom, pomContent, {encoding: 'utf-8'});
}
});
}

gulp.task('java:build', shell.task('mvn package javadoc:aggregate -DskipTests=true -q'));
gulp.task('java:stage', ['java:build'], function(){
return gulp.src('./target/site/apidocs/**/*').pipe(gulp.dest('./dist'));
Expand Down