Skip to content

Conversation

@chenrujun
Copy link

No description provided.

@chenrujun
Copy link
Author

Hi, @JimSuplizio ,
Please review. 🙏

Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the dependent spring boot version to 2.3.0 too.

@chenrujun chenrujun requested a review from saragluna June 16, 2020 05:57
@chenrujun
Copy link
Author

Hi, @saragluna .

We need to update the dependent spring boot version to 2.3.0 too.

Updated, please check again. 🙏

@chenrujun chenrujun force-pushed the apply-PR-from-old-repo-895-902-915 branch from 5de43c6 to ee76066 Compare June 16, 2020 06:02
Copy link
Contributor

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, the version_client.txt changes should probably be discarded and started from scratch. The only changes that needed to be done to that file were updates to the dependency/current versions.

@chenrujun chenrujun force-pushed the apply-PR-from-old-repo-895-902-915 branch from ee76066 to 6a84261 Compare June 17, 2020 03:39
@saragluna
Copy link
Member

/azp run java - spring - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link
Author

Hi, @saragluna .
Please merge it. 🙏

@saragluna saragluna merged commit 5b7d3f4 into Azure:master Jun 18, 2020
@chenrujun chenrujun deleted the apply-PR-from-old-repo-895-902-915 branch June 18, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants