-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use release version instead of current version in spring sample projects #14301
Use release version instead of current version in spring sample projects #14301
Conversation
Hi, @saragluna , @JimSuplizio . |
Hey @JimSuplizio, does this change look valid to you? @chenrujun will the versions in the sample projects be updated too when running the update_version script now? |
Yes, this command will update versions in sample projects:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I would like to start seeing descriptions in your PRs. This one is relatively straightforward, at least for the version changes, but I had to exhaustively go though to your changes to the scripts to effectively see what was going on there.
- The changes to both the update_versions.py and set_versions.py consist of 1 spelling error (externaly to external ), some formatting changes and some rearranging of the from/import (which is no more consistent to what was actually there). If there was a bug fix that would be fine but there isn't and as such, these changes do no belong in this PR. If you feel the need to reformat and update these then please do it in a separate PR.
1df21b8
to
b630bdd
Compare
Updated this PR according to Jim's feedback.
Hey @JimSuplizio, @chenrujun has tested these changes locally and the dependency versions could be updated correctly when we perform releases. So I'm going to approve this PR now and plan to merge it tomorrow. Let me know if you have any concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Add configuration to generate AppPlatform SDK for API version 2021-06-01-preview (Azure#14301) * Add configuration to generate AppPlatform SDK for API version 2021-03-03-preview * Update AutoRest configuration after api-version change in Azure#14323
No description provided.