Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use release version instead of current version in spring sample projects #14301

Conversation

chenrujun
Copy link

No description provided.

@chenrujun
Copy link
Author

Hi, @saragluna , @JimSuplizio .
Please review. 🙏

@saragluna
Copy link
Member

Hey @JimSuplizio, does this change look valid to you? @chenrujun will the versions in the sample projects be updated too when running the update_version script now?

@chenrujun
Copy link
Author

@saragluna

will the versions in the sample projects be updated too when running the update_version script now?

Yes, this command will update versions in sample projects:

python eng/versioning/update_versions.py --ut library --bt client --sr

Copy link
Member

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenrujun

  1. I would like to start seeing descriptions in your PRs. This one is relatively straightforward, at least for the version changes, but I had to exhaustively go though to your changes to the scripts to effectively see what was going on there.
  2. The changes to both the update_versions.py and set_versions.py consist of 1 spelling error (externaly to external ), some formatting changes and some rearranging of the from/import (which is no more consistent to what was actually there). If there was a bug fix that would be fine but there isn't and as such, these changes do no belong in this PR. If you feel the need to reformat and update these then please do it in a separate PR.

@chenrujun
Copy link
Author

@JimSuplizio

I would like to start seeing descriptions in your PRs. This one is relatively straightforward, at least for the version changes, but I had to exhaustively go though to your changes to the scripts to effectively see what was going on there.

I write some information in the commit message. Like:
2020-08-25 090900

The changes to both the update_versions.py and set_versions.py consist of 1 spelling error (externaly to external ), some formatting changes and some rearranging of the from/import (which is no more consistent to what was actually there). If there was a bug fix that would be fine but there isn't and as such, these changes do no belong in this PR. If you feel the need to reformat and update these then please do it in a separate PR.

Actually, for the scripts, there is not logic change, just format code or fix typo. I added message in the commit info.
When merge the PR, if the commits will not been squashed, I think it's OK to merge.
Since the commit info will be squashed, I'll recover the scripts in this PR.

@chenrujun chenrujun force-pushed the use-release-version-instead-of-current-version-in-spring-sample-projects branch from 1df21b8 to b630bdd Compare August 25, 2020 01:20
@chenrujun chenrujun requested a review from JimSuplizio August 25, 2020 01:20
@chenrujun chenrujun dismissed JimSuplizio’s stale review August 25, 2020 01:21

Updated this PR according to Jim's feedback.

@saragluna
Copy link
Member

Hey @JimSuplizio, @chenrujun has tested these changes locally and the dependency versions could be updated correctly when we perform releases. So I'm going to approve this PR now and plan to merge it tomorrow. Let me know if you have any concerns.

Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun chenrujun merged commit f5a2840 into Azure:master Aug 26, 2020
@chenrujun chenrujun deleted the use-release-version-instead-of-current-version-in-spring-sample-projects branch August 26, 2020 02:27
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Jun 8, 2021
Add configuration to generate AppPlatform SDK for API version 2021-06-01-preview (Azure#14301)

* Add configuration to generate AppPlatform SDK for API version 2021-03-03-preview

* Update AutoRest configuration after api-version change in Azure#14323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants