mgmt add azure-resourcemanager-eventhubs #14469
Conversation
xseeseesee
requested review from
alzimmermsft,
ChenTanyi,
danieljurek,
JimSuplizio,
mitchdenny,
samvaity,
weidongxu-microsoft,
weshaggard and
yungezz
as code owners
...eventhubs/src/main/java/com/azure/resourcemanager/eventhubs/implementation/EventHubImpl.java
Outdated
Show resolved
Hide resolved
...eventhubs/src/main/java/com/azure/resourcemanager/eventhubs/implementation/EventHubImpl.java
Outdated
Show resolved
Hide resolved
...eventhubs/src/main/java/com/azure/resourcemanager/eventhubs/implementation/EventHubImpl.java
Outdated
Show resolved
Hide resolved
.../com/azure/resourcemanager/eventhubs/implementation/EventHubDisasterRecoveryPairingImpl.java
Show resolved
Hide resolved
.../com/azure/resourcemanager/eventhubs/implementation/EventHubDisasterRecoveryPairingImpl.java
Show resolved
Hide resolved
...eventhubs/src/main/java/com/azure/resourcemanager/eventhubs/implementation/EventHubImpl.java
Show resolved
Hide resolved
|
@xccc-msft Do you have a few files that need deep review? (again, too many files, and changes across multiple commits so it also hard to review by commit). |
|
|
||
| private Mono<Indexable> createContainerIfNotExistsAsync(final StorageAccount storageAccount, | ||
| final String containerName) { | ||
| return storageManager.blobContainers() |
There was a problem hiding this comment.
@weidongxu-microsoft This is the main changes after migration. I apply azure-resourcemanager-storage for the scenario to create a container if not exists instead of using azure-storage/azure-storage-blob. The rest part keeps as it is.
| @Override | ||
| public EventHubImpl withNewSendRule(final String ruleName) { | ||
| addPostRunDependent(context -> manager().eventHubAuthorizationRules() | ||
| .define(ruleName) | ||
| .withExistingEventHub(ancestor().resourceGroupName(), ancestor().ancestor1Name(), name()) | ||
| .withSendAccess() | ||
| .createAsync() | ||
| .last()); | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public EventHubImpl withNewListenRule(final String ruleName) { | ||
| addPostRunDependent(context -> manager().eventHubAuthorizationRules() | ||
| .define(ruleName) | ||
| .withExistingEventHub(ancestor().resourceGroupName(), ancestor().ancestor1Name(), name()) | ||
| .withListenAccess() | ||
| .createAsync() | ||
| .last()); | ||
| return this; | ||
| } |
There was a problem hiding this comment.
Please try test case which do both (NewSend and NewListen) in one Create/Update. I remember service not able to handle concurrent requests under eventhub, so these had to be done in sequence.
Azure/azure-libraries-for-net#891
There was a problem hiding this comment.
Do they have without method?
There was a problem hiding this comment.
I will add new method withNewSendAndListenRule(ruleName). There is withoutAuthorizationRule(ruleName) to remove the authorization rule no matter what access it has.
There was a problem hiding this comment.
Eh, I didn't get it. What I mean is these REST requests under "eventhub" might need to be called sequentially, it might not be limited to this 2.
There was a problem hiding this comment.
After discuss offline, we decide to concat the post run tasks in eventhubs.
...eventhubs/src/main/java/com/azure/resourcemanager/eventhubs/implementation/EventHubImpl.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/azure/resourcemanager/eventhubs/implementation/EventHubNamespaceImpl.java
Outdated
Show resolved
Hide resolved
No description provided.