Query annotation support #14661
Merged
Query annotation support #14661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbhaskar
requested review from
chenrujun,
jialindai,
kushagraThapar,
saragluna,
yiliuTo and
zhoufenqin
as code owners
ghost
added
the
chenrujun
suggested changes
Sep 2, 2020
...data-cosmos-core/src/main/java/com/azure/spring/data/cosmos/core/ReactiveCosmosTemplate.java
Show resolved
Hide resolved
...src/main/java/com/azure/spring/data/cosmos/repository/query/AbstractReactiveCosmosQuery.java
Show resolved
Hide resolved
...smos-core/src/main/java/com/azure/spring/data/cosmos/repository/query/CosmosQueryMethod.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/azure/spring/data/cosmos/repository/query/ReactiveCosmosQueryMethod.java
Outdated
Show resolved
Hide resolved
...smos-core/src/main/java/com/azure/spring/data/cosmos/repository/query/CosmosQueryMethod.java
Show resolved
Hide resolved
...test/src/test/java/com/azure/spring/data/cosmos/repository/repository/ContactRepository.java
Outdated
Show resolved
Hide resolved
...t/src/test/java/com/azure/spring/data/cosmos/repository/integration/ContactRepositoryIT.java
Show resolved
Hide resolved
...t/src/test/java/com/azure/spring/data/cosmos/repository/integration/ContactRepositoryIT.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/azure/spring/data/cosmos/repository/repository/ReactiveCourseRepository.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/azure/spring/data/cosmos/repository/repository/ReactiveCourseRepository.java
Outdated
Show resolved
Hide resolved
|
/azp run java - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chenrujun
suggested changes
Sep 7, 2020
...smos-core/src/main/java/com/azure/spring/data/cosmos/repository/query/CosmosQueryMethod.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/azure/spring/data/cosmos/repository/query/ReactiveCosmosQueryMethod.java
Show resolved
Hide resolved
chenrujun
reviewed
Sep 7, 2020
...smos-core/src/main/java/com/azure/spring/data/cosmos/repository/query/CosmosQueryMethod.java
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chenrujun
approved these changes
Sep 8, 2020
|
/azp run java - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
requested changes
Sep 9, 2020
There was a problem hiding this comment.
LGTM, @mbhaskar - can you please add query annotation sample code to the readme so that we can mark this as feature complete?
I will do that once the PR is in. Thanks |
kushagraThapar
approved these changes
Sep 9, 2020
… add annotated queries to their repositories using @query(value = "<query>") which opens up all the query capabilities of underlying cosmos java sdk to the cosmos spring driver.
mbhaskar
force-pushed
the
mbhaskar/query-annotation-support
branch
from
4722fbe to
0888f19
Compare
|
/azp run java - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
test pipeline already run. Rebased and pushed to get failing build analyze job to pass. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables end users to add annotated queries to their repositories using @query(value = "") which opens up all the query capabilities of underlying cosmos java sdk to the cosmos spring driver.
Examples
Synchronous:
Reactive:
#12714: Support
@Queryannotation from spring-data-commonsCloses: #12714