Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation of DT Apis #14671

Merged
merged 4 commits into from
Sep 1, 2020
Merged

Add implementation of DT Apis #14671

merged 4 commits into from
Sep 1, 2020

Conversation

bikamani
Copy link
Contributor

@bikamani bikamani commented Sep 1, 2020

No description provided.

abhipsaMisra
abhipsaMisra reviewed Sep 1, 2020
View reviewed changes
...ure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsAsyncClient.java
public Mono<Void> updateDigitalTwin(String digitalTwinId, List<Object> digitalTwinUpdateOperations)
{
return updateDigitalTwinWithResponse(digitalTwinId, digitalTwinUpdateOperations, new RequestOptions())
.flatMap(voidResponse -> Mono.empty());
Copy link
Member

@abhipsaMisra abhipsaMisra Sep 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: using a map here would have given us:
.map(voidDigitalTwinsResponse -> null)

Even though Mono<Void> is the same as an empty Mono -> Mono that doesn't return anything, I feel Mono.empty() is a better representation of the transformation we are doing here.

However, I want to point out that the end result from both would still be the same.

abhipsaMisra
abhipsaMisra approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@abhipsaMisra abhipsaMisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments, looks good otherwise!

@abhipsaMisra
Copy link
Member

an mvn install locally will highlight javadoc errors and other bug checks that the pipeline has

@bikamani bikamani merged commit 49d7bb5 into master Sep 1, 2020
@bikamani bikamani deleted the feature/adt/bikamani/dtCrud branch September 1, 2020 21:03
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Jun 15, 2021
CodeGen from PR 14671 in Azure/azure-rest-api-specs
834c895 
Resume V2021-02-01-Preview BackupShortTermRetentionPolicies API Specification (Azure#14671)

* Resume V2021-02-01-Preview BackupShortTermRetentionPolicies API Specification

* Prettier check fix

* comment

Co-authored-by: Lillian Liu <liulu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtay-microsoft timtay-microsoft timtay-microsoft left review comments

@abhipsaMisra abhipsaMisra abhipsaMisra approved these changes

@drwill-ms drwill-ms drwill-ms approved these changes

@azabbasi azabbasi Awaiting requested review from azabbasi

@barustum barustum Awaiting requested review from barustum

@prmathur-microsoft prmathur-microsoft Awaiting requested review from prmathur-microsoft

@vinagesh vinagesh Awaiting requested review from vinagesh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bikamani @abhipsaMisra @drwill-ms @timtay-microsoft