Fixes management support for AuthorizationRules #14865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion of SharedAccessAuthorizationRule.
conniey
added
Service Bus
Client
hemanttanwar
approved these changes
Sep 9, 2020
| // each XML element to be prefaced with an explicit namespace. For example: | ||
| // xmlns="foo" works because "foo" is assigned the global namespace. | ||
| // xmlns:ns0="foo", and then prefixing all elements with ns0:AuthorizationRule will break. | ||
| if (object instanceof CreateQueueBody) { |
There was a problem hiding this comment.
Should there be else when it is not instance of CreateQueueBody, should we log it ?
There was a problem hiding this comment.
If it's not an instance, it will just be the normal case where can return as is. This is a special case.
| </Rights> | ||
| <KeyName>test-name</KeyName> | ||
| <PrimaryKey>/4jWkzKBFwO0VemXmUYtBnXJ3Me+saF8hQPE5HzJ/hg=</PrimaryKey> | ||
| <SecondaryKey>NsNSEwj//k4ShF7wHsRHj54HsjnyWvyjmfCd3tfXR2Y=</SecondaryKey> |
There was a problem hiding this comment.
Are we supposed to add these keys here ?
There was a problem hiding this comment.
Yeah. They're keys to deleted sb instances now. I can change them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthorizationRules were not currently supported.