Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Enable SAS support in connection string for Service Bus #14939

Merged
merged 3 commits into from
Sep 9, 2020

Conversation

srnagar
Copy link
Member

@srnagar srnagar commented Sep 9, 2020

This PR adds support to include SharedAccessSignature token in the connection string.

More details and discussion can be found here: Azure/azure-sdk#1701

This is similar to the Event hubs PR - #14912

Copy link
Contributor

@YijunXieMS YijunXieMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hemanttanwar hemanttanwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comments.

@srnagar srnagar merged commit ca756d5 into Azure:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants