Feat(client): Add Telemetry APIs #15047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azabbasi
requested review from
abhipsaMisra,
barustum,
bikamani,
drwill-ms,
timtay-microsoft and
vinagesh
as code owners
ghost
added
the
...azure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/util/TelemetryOptions.java
Outdated
Show resolved
Hide resolved
...azure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/util/TelemetryOptions.java
Outdated
Show resolved
Hide resolved
...azure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/util/TelemetryOptions.java
Outdated
Show resolved
Hide resolved
...ure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsAsyncClient.java
Outdated
Show resolved
Hide resolved
|
We'll need a String/T set of these APIs like we have with relationship/component/digital twin APIs, right? The telemetry payload is an untyped json object much like those other APIs |
I am actually not convinced that we should, there is no return type to cast to, so we can either take an object and pass it down to protocol layer, or take a string and do the casting on our own. let's discuss that in our session on Monday. for the time being, I will cast the string into json string object. |
...ure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsAsyncClient.java
Outdated
Show resolved
Hide resolved
...ure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsAsyncClient.java
Outdated
Show resolved
Hide resolved
timtay-microsoft
approved these changes
Sep 10, 2020
bikamani
approved these changes
Sep 10, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jul 1, 2021
Remove files from package which are not part of management plane SDK - update readme.md (Azure#15047) * Update readme.md * Update readme.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.