Added support to specify block size in BlobInputStream #15496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gapra-msft
changed the title
gapra-msft
requested review from
alzimmermsft,
amishra-dev,
jaschrep-msft,
kasobol-msft and
rickle-msft
as code owners
rickle-msft
approved these changes
Sep 23, 2020
gapra-msft
added
the
APIChange
|
@alzimmermsft Could you take a look at this PR for API feedback? |
| BlobRange range = options.getRange() == null ? new BlobRange(0) : options.getRange(); | ||
| int chunkSize = options.getBlockSize() == null ? 4 * Constants.MB : options.getBlockSize(); | ||
|
|
||
| return new BlobInputStream(client, range.getOffset(), range.getCount(), chunkSize, |
There was a problem hiding this comment.
So this is a minor change where we will make an additional service call to get the properties of the blob before opening the stream. Are we okay with that? If so, we should add a quick document stating that we will be doing this as it is a behavioral change from the past.
There was a problem hiding this comment.
Actually I think we already called getProperties before, I just moved it outside since we can't call it in the constructor before a call to super
alzimmermsft
approved these changes
Sep 23, 2020
| /** | ||
| * @return The size of each data chunk returned from the service. If block size is large, input stream will make | ||
| * fewer network calls, but each individual call will send more data and will therefore take longer. | ||
| * The default value is 4 MB. |
There was a problem hiding this comment.
If we are going to say the default if 4 MB should the getter check for blockSize == null and return 4 * Constants.MB?
return (blockSize == null) ? 4 * Constants.MB : blockSize;If this change is made, we could also change the return type to int instead of Integer.
There was a problem hiding this comment.
Should we tie this type to promising that? I'm a little hesitant to do that. I'd prefer it just be normal fluent behavior
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Dec 13, 2021
[DO NOT MERGE]Dev resourcemover microsoft.migrate 2021 08 01 (Azure#15496) * Adds base for updating Microsoft.Migrate from version stable/2021-01-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * Added systemData property in Move Collection & Move Resource object * Update resourcemovercollection.json Added Tags and User-Managed Identities Properties * Update resourcemovercollection.json Made changes for removing tags property for document resources and resource group. * Removed additional empty line * Swagger PrettierCheck * Updating examples for 2021-08-01 version. * CI Fix Co-authored-by: Anany Shah <anashah@microsoft.com> Co-authored-by: yashjain4 <87814230+yashjain4@users.noreply.github.com>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jan 5, 2022
[DO NOT MERGE]Dev resourcemover microsoft.migrate 2021 08 01 (Azure#15496) * Adds base for updating Microsoft.Migrate from version stable/2021-01-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * Added systemData property in Move Collection & Move Resource object * Update resourcemovercollection.json Added Tags and User-Managed Identities Properties * Update resourcemovercollection.json Made changes for removing tags property for document resources and resource group. * Removed additional empty line * Swagger PrettierCheck * Updating examples for 2021-08-01 version. * CI Fix Co-authored-by: Anany Shah <anashah@microsoft.com> Co-authored-by: yashjain4 <87814230+yashjain4@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14739