Adds RNTBD Service Endpoint Statistics to request diagnostics #15564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moderakh
requested review from
David-Noble-at-work,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
simplynaveen20 and
xinlian12
as code owners
ghost
added
the
|
Nice! There are two taskQueues (channelPool, channel), would capturing both of them be useful? |
…statistics-to-diagnostics
FabianMeiswinkel
approved these changes
Sep 25, 2020
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kirankumarkolli
approved these changes
Sep 25, 2020
|
Thanks for covering both the task queue length. |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer override |
|
Merging on @moderakh 's request. |
moderakh
deleted the
users/moderakh/add-rntbd-service-endpoint-statistics-to-diagnostics
branch
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Sep 9, 2021
Merge Dev-containerservice-microsoft.containerservice-2021-08-01 branch to main (Azure#15954) * Adds base for updating Microsoft.ContainerService from version stable/2021-07-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * add publicNetworkAccess property per network platform's request (Azure#15489) * add publicNetworkAccess per network platform's request * fix quota Co-authored-by: Li Ma <lima2@microsoft.com> * update readme for 2021-08-01 sdk generation (Azure#15476) * update readme for sdk generation * update readme for sdk generation Co-authored-by: Charlie Li <charlili@microsoft.com> * allow disabling of runcommand (Azure#15481) * allow disabling of runcommand * rename file * another rename * fix prittier check * fix stupid prettier check * change publicNetworkAccess to enum (Azure#15564) Co-authored-by: Li Ma <lima2@microsoft.com> * Add CreationData property to Agentpool level in 2021-08-01 API (Azure#15563) * Add CreationData property to Agentpool level in 2021-08-01 API * fix json format * fix swagger spell check Co-authored-by: Charlie Li <charlili@microsoft.com> * chore: add enableMultipleStandardLoadBalancers to loadBalancerProfile (Azure#15579) * Add snapshot related new APIs and properties to AKS 2021-08-01 swagger (Azure#15586) * Add CreationData property to Agentpool level in 2021-08-01 API * Add snapshot related APIs and properties to AKS 2021-08-01 swagger * fix lint and spell checks * fix lint and spell checks * fix PrettierCheck * Change some Nodepool to NodePool * some changes according to ARM team's review comments Co-authored-by: Charlie Li <charlili@microsoft.com> * fix tag typo to match tag convention (Azure#15683) * add workload runtime to agent pool api (Azure#15726) * add workload runtime to agent pool api * reference example * add custom words * fix: workload runtime description (Azure#15782) * fix: workload runtime description * add wasmtime to custom words * clarify single workload type per node Co-authored-by: Matthew Christopher <matthchr@microsoft.com> Co-authored-by: Matthew Christopher <matthchr@microsoft.com> * fix typo in readme.python.md (Azure#15903) * Add CreationData property to Agentpool level in 2021-08-01 API * fix typos in readme.python.md Co-authored-by: Charlie Li <charlili@microsoft.com> * merge recent custom-words.txt changes from main branch to resolve conflicts (Azure#15938) * Add CreationData property to Agentpool level in 2021-08-01 API * merge recent custom-words.txt changes from main branch to resolve conflicts Co-authored-by: Charlie Li <charlili@microsoft.com> * pull custom-words.txt from main * add a new word - NodePool * add two more words Co-authored-by: Super <mali_no2@hotmail.com> Co-authored-by: Li Ma <lima2@microsoft.com> Co-authored-by: Charlie Li <charlili@microsoft.com> Co-authored-by: Haitao Chen <haitch@users.noreply.github.com> Co-authored-by: Qi Ni <pomelonicky@gmail.com> Co-authored-by: Ariel Silverman <asilverman@users.noreply.github.com> Co-authored-by: Ace Eldeib <alexeldeib@gmail.com> Co-authored-by: Matthew Christopher <matthchr@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds RNTBD Service Endpoint Statistics to request diagnostics, the following section added to the request diagnostics:
complete request diagnostics:
{ "userAgent": "azsdk-java-cosmos/4.6.0-beta.1 MacOSX/10.15.6 JRE/11.0.6", "requestLatencyInMs": 1, "requestStartTimeUTC": "2020-09-25T17:13:28.217060Z", "requestEndTimeUTC": "2020-09-25T17:13:28.218749Z", "connectionMode": "DIRECT", "responseStatisticsList": [{ "storeResult": { "storePhysicalAddress": "rntbd://10.37.129.3:10253/apps/DocDbApp/services/DocDbServer2/partitions/a4cb494e-38c8-11e6-8106-8cdcd42c33be/replicas/1p/", "lsn": 1712, "globalCommittedLsn": -1, "partitionKeyRangeId": "1", "isValid": true, "statusCode": 200, "subStatusCode": 0, "isGone": false, "isNotFound": false, "isInvalidPartition": false, "requestCharge": 1.0, "itemLSN": 1712, "sessionToken": "-1#1712", "exception": null, "transportRequestTimeline": [{ "eventName": "created", "durationInMicroSec": "12", "startTime": "2020-09-25T17:13:28.217489Z" }, { "eventName": "queued", "durationInMicroSec": "150", "startTime": "2020-09-25T17:13:28.217501Z" }, { "eventName": "pipelined", "durationInMicroSec": "202", "startTime": "2020-09-25T17:13:28.217651Z" }, { "eventName": "transitTime", "durationInMicroSec": "799", "startTime": "2020-09-25T17:13:28.217853Z" }, { "eventName": "received", "durationInMicroSec": "60", "startTime": "2020-09-25T17:13:28.218652Z" }, { "eventName": "completed", "durationInMicroSec": "1", "startTime": "2020-09-25T17:13:28.218712Z" }], "rntbdRequestLengthInBytes": 419, "rntbdResponseLengthInBytes": 769, "requestPayloadLengthInBytes": 0, "responsePayloadLengthInBytes": 303, "channelTaskQueueSize": 1, "pendingRequestsCount": 0, "serviceEndpointStatistics": { "availableChannels": 1, "acquiredChannels": 0, "executorTaskQueueSize": 0, "inflightRequests": 1, "lastSuccessfulRequestTime": "2020-09-25T17:13:28.216Z", "lastRequestTime": "2020-09-25T17:13:28.215Z", "createdTime": "2020-09-25T17:13:26.312417Z", "isClosed": false } }, "requestResponseTimeUTC": "2020-09-25T17:13:28.218749Z", "requestResourceType": "Document", "requestOperationType": "Read" }], "supplementalResponseStatisticsList": [], "addressResolutionStatistics": {}, "regionsContacted": ["https://10.37.129.3:8081/"], "retryContext": { "retryCount": 0, "statusAndSubStatusCodes": null, "retryLatency": 0 }, "metadataDiagnosticsContext": { "metadataDiagnosticList": null }, "serializationDiagnosticsContext": { "serializationDiagnosticsList": [{ "serializationType": "ITEM_DESERIALIZATION", "startTimeUTC": "2020-09-25T17:13:28.218997Z", "endTimeUTC": "2020-09-25T17:13:28.219078Z", "durationInMicroSec": 81 }] }, "gatewayStatistics": null, "systemInformation": { "usedMemory": "77483 KB", "availableMemory": "16699733 KB", "systemCpuLoad": "empty" } }