RntbdBugFix #16204
Merged
RntbdBugFix #16204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinlian12
requested review from
David-Noble-at-work,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
moderakh and
simplynaveen20
as code owners
ghost
added
the
moderakh
reviewed
Oct 12, 2020
| @@ -78,13 +79,16 @@ public static RntbdRequest decode(final ByteBuf in) { | |||
| void encode(final ByteBuf out) { | |||
|
|
|||
| final int expectedLength = RntbdRequestFrame.LENGTH + this.headers.computeLength(); | |||
| final int start = out.readerIndex(); | |||
| final int start = out.writerIndex(); | |||
There was a problem hiding this comment.
could you please explain the scenario which this bug shows itself?
why do we need this?
There was a problem hiding this comment.
This change was originally found and fixed in PR https://github.com/Azure/azure-sdk-for-java/pull/14697/files#diff-cdd54a91cbc899239eec06998abac39eL81.
We have not came across any issue today since the writerIndex and readerIndex should be the same. But the writerIndex is the more correct value we should use.
But also feel it may be a risk to depend on the underlying ByteBuf implementation details.
So it is better to change to use the right value.
There was a problem hiding this comment.
I just read the whole code. makes sense to use writerIndex. thanks
7 tasks
...mos/src/main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdRequest.java
Outdated
Show resolved
Hide resolved
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Oct 8, 2021
update readme (Azure#16204)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was detected in PR #14697.
WriterIndex and readerIndex should be same when the method is called, but the more correct value to use is writerIndex.