Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite index support #18447

Merged
merged 6 commits into from
Jan 6, 2021
Merged

Conversation

Blackbaud-EricSlater
Copy link
Contributor

@Blackbaud-EricSlater Blackbaud-EricSlater commented Jan 5, 2021

extend CosmosIndexPolicy annotation to support composite indexes

this partially addresses this issue #17535

@ghost ghost added Cosmos azure-spring All azure-spring related issues customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jan 5, 2021
@ghost
Copy link

ghost commented Jan 5, 2021

Thank you for your contribution Blackbaud-EricSlater! We will review the pull request and get back to you soon.

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, thanks @Blackbaud-EricSlater
Except for new file headers missing

@@ -0,0 +1,70 @@
package com.azure.spring.data.cosmos.domain;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new file header missing

@@ -0,0 +1,141 @@
package com.azure.spring.data.cosmos.repository.integration;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new file header missing

@@ -0,0 +1,17 @@
package com.azure.spring.data.cosmos.core.mapping;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new file header missing

@@ -0,0 +1,25 @@
package com.azure.spring.data.cosmos.core.mapping;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new file header missing

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@kushagraThapar
Copy link
Member

/azp run java - cosmos - test

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@kushagraThapar
Copy link
Member

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kushagraThapar kushagraThapar merged commit 87d145c into Azure:master Jan 6, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Apr 7, 2022
[OperationalInsights] Rename 'eTag' property to 'etag'  (Azure#18447)

* Add blockchain to latest profile

* Add additional types

* Renamed 'eTag' to 'etag' same as all other ARM resources

* rename 'eTag' to 'etag'

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants