-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composite index support #18447
Composite index support #18447
Conversation
Thank you for your contribution Blackbaud-EricSlater! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, thanks @Blackbaud-EricSlater
Except for new file headers missing
@@ -0,0 +1,70 @@ | |||
package com.azure.spring.data.cosmos.domain; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new file header missing
@@ -0,0 +1,141 @@ | |||
package com.azure.spring.data.cosmos.repository.integration; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new file header missing
@@ -0,0 +1,17 @@ | |||
package com.azure.spring.data.cosmos.core.mapping; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new file header missing
@@ -0,0 +1,25 @@ | |||
package com.azure.spring.data.cosmos.core.mapping; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new file header missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again!
/azp run java - cosmos - test |
No pipelines are associated with this pull request. |
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
[OperationalInsights] Rename 'eTag' property to 'etag' (Azure#18447) * Add blockchain to latest profile * Add additional types * Renamed 'eTag' to 'etag' same as all other ARM resources * rename 'eTag' to 'etag' Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
extend CosmosIndexPolicy annotation to support composite indexes
this partially addresses this issue #17535