Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update spring-cloud-azure-appconfiguration-* dependency in sa… #19873

Merged
merged 3 commits into from
Mar 17, 2021
Merged

update spring-cloud-azure-appconfiguration-* dependency in sa… #19873

merged 3 commits into from
Mar 17, 2021

Conversation

backwind1233
Copy link
Contributor

@backwind1233 backwind1233 commented Mar 16, 2021

Prepare an OOB release for spring-cloud-azure-appconfiguration-* 1.2.9 with branch hotfix/app-config-1.2.9.

@ghost ghost added App Configuration Azure.ApplicationModel.Configuration azure-spring All azure-spring related issues labels Mar 16, 2021
@backwind1233
Copy link
Contributor Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@backwind1233 backwind1233 self-assigned this Mar 16, 2021
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -20,7 +20,7 @@
<dependency>
<groupId>com.microsoft.azure</groupId>
<artifactId>spring-cloud-starter-azure-appconfiguration-config</artifactId>
<version>1.2.8</version> <!-- {x-version-update;com.microsoft.azure:spring-cloud-starter-azure-appconfiguration-config;current} -->
<version>1.2.9</version> <!-- {x-version-update;com.microsoft.azure:spring-cloud-starter-azure-appconfiguration-config;current} -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it's not updated automatically?

@@ -62,7 +62,7 @@
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-data-appconfiguration</artifactId>
<version>1.2.0-beta.1</version> <!-- {x-version-update;com.azure:azure-data-appconfiguration;current} -->
<version>1.1.9</version> <!-- {x-version-update;com.azure:azure-data-appconfiguration;dependency} -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use dependency, because they are released by different team?

@backwind1233
Copy link
Contributor Author

/azp run java - spring - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@backwind1233
Copy link
Contributor Author

/azp run java - appconfiguration - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@backwind1233 backwind1233 merged commit 21526ac into Azure:hotfix/app-config-1.2.9 Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Azure.ApplicationModel.Configuration azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants