Fix for bulk operations incorrect routing on split #21420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbhaskar
requested review from
aayush3011,
FabianMeiswinkel,
kirankumarkolli,
kushagraThapar,
milismsft,
moderakh,
simplynaveen20 and
xinlian12
as code owners
ghost
added
the
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ValidationTests::splitQueryContinuationToken
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…eedDocumentsAfterSplit()
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosBulkGatewayTest.java
Outdated
Show resolved
Hide resolved
FabianMeiswinkel
approved these changes
May 14, 2021
ealsur
approved these changes
May 14, 2021
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/batch/BulkExecutor.java
Outdated
Show resolved
Hide resolved
...ure-cosmos/src/main/java/com/azure/cosmos/implementation/batch/BulkOperationRetryPolicy.java
Outdated
Show resolved
Hide resolved
...re-cosmos/src/main/java/com/azure/cosmos/implementation/caches/RxPartitionKeyRangeCache.java
Outdated
Show resolved
Hide resolved
moderakh
approved these changes
May 14, 2021
moderakh
reviewed
May 14, 2021
Implementing PR comments Increasing timeout on tests
Only GW mode is effected by this bug. |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer evaluate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a collection split occurs during bulk opertions, the requests were still being retried on the original partition as the partitionkeyrange cache that helps in routing was not being refreshed correctly. The effect is that the user received a failure with a status code 410 and substatus code 1002.
This PR addresses the above issue by refreshing the partitionkeyrange cache when a collection split occurs
Fixes #21126